r76950 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r76949‎ | r76950 | r76951 >
Date:18:32, 18 November 2010
Author:awjrichards
Status:deferred
Tags:
Comment:
Merging from r76909 thru r76949 of trunk
Modified paths:
  • /branches/fundraising/deployment/DonationInterface (modified) (history)
  • /branches/fundraising/deployment/DonationInterface/payflowpro_gateway/forms/TwoStepTwoColumnLetter.php (modified) (history)
  • /branches/fundraising/deployment/DonationInterface/payflowpro_gateway/forms/TwoStepTwoColumnLetterCA.php (modified) (history)

Diff [purge]

Index: branches/fundraising/deployment/DonationInterface/payflowpro_gateway/forms/TwoStepTwoColumnLetter.php
@@ -54,7 +54,7 @@
5555
5656 // Xml::element seems to convert html to htmlentities
5757 $form .= "<p class='creditcard-error-msg'>" . $this->form_errors['retryMsg'] . "</p>";
58 - $form .= Xml::openElement( 'form', array( 'name' => 'payment', 'method' => 'post', 'action' => $this->getNoCacheAction(), 'onsubmit' => 'return validate_form(this)', 'autocomplete' => 'off' ) );
 58+ $form .= Xml::openElement( 'form', array( 'name' => 'payment', 'method' => 'post', 'action' => $this->getNoCacheAction(), 'onsubmit' => 'return formCheck(this)', 'autocomplete' => 'off' ) );
5959
6060 $form .= $this->generateBillingContainer();
6161 return $form;
Index: branches/fundraising/deployment/DonationInterface/payflowpro_gateway/forms/TwoStepTwoColumnLetterCA.php
@@ -54,7 +54,7 @@
5555
5656 // Xml::element seems to convert html to htmlentities
5757 $form .= "<p class='creditcard-error-msg'>" . $this->form_errors['retryMsg'] . "</p>";
58 - $form .= Xml::openElement( 'form', array( 'name' => 'payment', 'method' => 'post', 'action' => $this->getNoCacheAction(), 'onsubmit' => 'return validate_form(this)', 'autocomplete' => 'off' ) );
 58+ $form .= Xml::openElement( 'form', array( 'name' => 'payment', 'method' => 'post', 'action' => $this->getNoCacheAction(), 'onsubmit' => 'return formCheck(this)', 'autocomplete' => 'off' ) );
5959
6060 $form .= $this->generateBillingContainer();
6161 return $form;
Property changes on: branches/fundraising/deployment/DonationInterface
___________________________________________________________________
Modified: svn:mergeinfo
6262 Merged /trunk/extensions/DonationInterface:r76909-76949

Follow-up revisions

RevisionCommit summaryAuthorDate
r76990Merging from r76950 thru r76989 of trunkawjrichards00:54, 19 November 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r76909Merging from r76904 thru r76908 of trunkawjrichards22:24, 17 November 2010
r76949Using XML methods rather than hard-coded HTML, as suggested by Aaron in bug 2...huji17:47, 18 November 2010

Status & tagging log