r76940 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r76939‎ | r76940 | r76941 >
Date:08:26, 18 November 2010
Author:raymond
Status:ok
Tags:
Comment:
Move span out of the message,
Some tweaks to messages and alias file for consistency
Add extension to Translatewiki
Modified paths:
  • /trunk/extensions/FlagPage/FlagPage.alias.php (modified) (history)
  • /trunk/extensions/FlagPage/FlagPage.body.php (modified) (history)
  • /trunk/extensions/FlagPage/FlagPage.i18n.php (modified) (history)
  • /trunk/extensions/FlagPage/FlagPage.php (modified) (history)
  • /trunk/extensions/Translate/groups/mediawiki-defines.txt (modified) (history)

Diff [purge]

Index: trunk/extensions/FlagPage/FlagPage.alias.php
@@ -1,12 +1,22 @@
22 <?php
3 -$aliases = array();
 3+$specialPageAliases = array();
44
5 -/** English */
6 -$aliases['en'] = array(
 5+/** English
 6+ * @author Church of emacs
 7+ */
 8+$specialPageAliases['en'] = array(
79 'FlagPage' => array( 'FlagPage' ),
810 );
911
10 -/** German (Deutsch) */
11 -$aliases['de'] = array(
 12+/** German (Deutsch)
 13+ * @author Church of emacs
 14+ */
 15+$specialPageAliases['de'] = array(
1216 'FlagPage' => array( 'Seite markieren'),
1317 );
 18+
 19+/**
 20+ * For backwards compatibility with MediaWiki 1.15 and earlier.
 21+ */
 22+$aliases =& $specialPageAliases;
 23+
Index: trunk/extensions/FlagPage/FlagPage.body.php
@@ -125,7 +125,7 @@
126126 }
127127 $id = Title::newFromText( $page )->getArticleId();
128128 if ($id==0) { # Page does not exist. Show preview page
129 - $wgOut->addWikiMsg( 'flagpage-nonexistent', $page );
 129+ $wgOut->wrapWikiMsg( "<div class='error plainlinks'>\n$1</div>\n", array( 'flagpage-nonexistent', $page ) );
130130 $this->preview( $page, $template );
131131 return;
132132 }
Index: trunk/extensions/FlagPage/FlagPage.i18n.php
@@ -1,26 +1,27 @@
22 <?php
33 $messages = array();
44
5 -/* *** English *** */
 5+/** English
 6+ * @author Church of emacs
 7+ */
68 $messages['en'] = array(
79 'flagpage' => 'Flag a page',
8 - 'flagpage-desc' => "Flag page with predefined templates",
9 - 'flagpage-templatelist' => "<!--
 10+ 'flagpage-desc' => 'Flag page with predefined templates',
 11+ 'flagpage-templatelist' => '<!--
1012 Edit this page to configure templates to use.
1113 Examples:
1214 * [[Template:Unsourced|The article does not cite any references]]
1315 * [[Template:NPOV|The article is written in a biased way]]
1416 * [[Template:Delete|The article should be deleted]]
15 -
 17+-->',
1618 'flagpage-nopageselectedtitle' => 'No page selected',
1719 'flagpage-nopageselected' => 'You did not specify a page',
1820 'flagpage-emptylisttitle' => 'No templates configured',
1921 'flagpage-emptylist' => 'You need to configure your lists of templates. Edit [[{{ns:8}}:flagpage-templatelist]] to do so now.',
2022 'flagpage-preview' => 'Preview of the selected template:',
21 - 'flagpage-confirmsave' => 'Please confirm your changes. ',
 23+ 'flagpage-confirmsave' => 'Please confirm your changes.',
2224 'flagpage-submitbutton' => 'Save page with this template',
23 - 'flagpage-nonexistent'=> '<span class="plainlinks">The page “$1” does not exist. Perhaps it has been [{{fullurl:Special:Log|page=$1}} moved or deleted].</span>',
 25+ 'flagpage-nonexistent'=> 'The page “$1” does not exist. Perhaps it has been [{{fullurl:Special:Log|page=$1}} moved or deleted].',
2426 'flagpage-summary' => 'Added template [[$1]] using FlagPage',
2527 'flagpage-success' => '[[$1]] has been added to the page [[$2]].',
2628 'flagpage-tab' => 'Flag'
Index: trunk/extensions/FlagPage/FlagPage.php
@@ -9,7 +9,7 @@
1010 'author' => 'Church of emacs',
1111 'url' => 'http://www.mediawiki.org/wiki/Extension:FlagPage',
1212 'descriptionmsg' => 'flagarticle-desc',
13 - 'version' => '0.1.1beta',
 13+ 'version' => '0.1.2beta',
1414 );
1515
1616 $dir = dirname(__FILE__) . '/';
Index: trunk/extensions/Translate/groups/mediawiki-defines.txt
@@ -430,6 +430,9 @@
431431
432432 Fixed Image
433433
 434+Flag Page
 435+aliasfile = FlagPag/FlagPag.alias.php
 436+
434437 Flagged Revisions - Flagged Revs
435438 id = ext-flaggedrevs-flaggedrevs
436439 file = FlaggedRevs/language/FlaggedRevs.i18n.php

Follow-up revisions

RevisionCommit summaryAuthorDate
r76963Follow-up r76940: article->page for consistency...raymond21:27, 18 November 2010
r76976Follow-up r76940: typoraymond22:04, 18 November 2010

Status & tagging log