r76880 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r76879‎ | r76880 | r76881 >
Date:11:43, 17 November 2010
Author:tstarling
Status:ok
Tags:
Comment:
Fix for r76088: if you want the Vector stylesheets you have to use the Vector document structure, not a mix of Vector, Monobook and JustPlainBroken.
Modified paths:
  • /trunk/phase3/includes/installer/WebInstallerOutput.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/installer/WebInstallerOutput.php
@@ -183,8 +183,8 @@
184184 </head>
185185
186186 <?php echo Html::openElement( 'body', array( 'class' => $this->getDir() ) ) . "\n"; ?>
187 -<div id="mw-page-base">
188 -<div id="mw-head-base">
 187+<div id="mw-page-base"></div>
 188+<div id="mw-head-base"></div>
189189 <div id="content">
190190 <div id="bodyContent">
191191
@@ -201,10 +201,10 @@
202202 }
203203 ?>
204204
205 -</div></div></div>
 205+</div></div>
206206
207207
208 -<div id="column-one">
 208+<div id="mw-panel">
209209 <div class="portlet" id="p-logo">
210210 <a style="background-image: url(../skins/common/images/mediawiki.png);"
211211 href="http://www.mediawiki.org/"

Follow-up revisions

RevisionCommit summaryAuthorDate
r77064Vector has 'body' as portlet class (Follow-up r76880), Monobook had 'pBody', ...krinkle20:09, 20 November 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r76088Dynamically generate CSS (using vector now). Handles RTL/LTR flip properly \o...demon13:14, 5 November 2010

Status & tagging log