r76844 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r76843‎ | r76844 | r76845 >
Date:23:02, 16 November 2010
Author:reedy
Status:resolved (Comments)
Tags:
Comment:
Variablise limit thingy
Modified paths:
  • /trunk/extensions/CodeReview/ui/CodeRevisionListView.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/ui/CodeRevisionListView.php
——@@ -43,11 +43,12 @@
4444 $wgUser->isAllowed( 'codereview-add-tag' );
4545
4646 $navBar = $pager->getNavigationBar();
 47+ $limitForm = $pager->getLimitForm();
4748
4849 $wgOut->addHTML(
4950 '<table><tr><td>' .
5051 $navBar .
51 - $pager->getLimitForm() .
 52+ $limitForm .
5253 '</td><td style="padding-left: 2em;">' .
5354 '&#160;<strong>' . wfMsgHtml( 'code-rev-total', $revCount ) . '</strong>' .
5455 '</td></tr></table>' .
——@@ -55,6 +56,7 @@
5657 array( 'action' => $pager->getTitle()->getLocalURL(), 'method' => 'post' )
5758 ) .
5859 $pager->getBody() .
 60+ $limitForm .
5961 $navBar .
6062 ( $this->batchForm ? $this->buildBatchInterface( $pager ) : "" ) .
6163 Xml::closeElement( 'form' )

Follow-up revisions

RevisionCommit summaryAuthorDate
r78395Fixup fixme on r76844...reedy18:17, 14 December 2010

Comments

#Comment by Reedy (talk | contribs)   23:04, 16 November 2010

Part of bug 25899, ease of transferring between machines working on...

#Comment by VasilievVV (talk | contribs)   22:19, 11 December 2010

This breaks bulk update form.

#Comment by Reedy (talk | contribs)   23:39, 11 December 2010

Hmm. Button clicks but doesn't do anything

Any idea why?

Relatedly, the bottom path search thing

#Comment by Reedy (talk | contribs)   00:13, 12 December 2010

It doesn't seem to be wrapped in a form element. Hacking it to be, gets it to submit, but not work.

I guess, it might not be this commit specifically, but one in this range.

It looks like the form tags have got weird, and one of them is hardcoded somewhere.

Running the svn version through the w3c validator... 

Saw a form start tag, but there was already an active form element. Nested forms are not allowed. Ignoring the tag.

Stray end tag form.


I'm taking a punt they're to blame, and with this refactoring has munged the html tags somewhere along the way, will poke at it tomorrow evening when I'm back on my desktop

#Comment by Reedy (talk | contribs)   17:24, 14 December 2010

Yeah, it's the moving of the form tags, which are done in some straange ways

Grrr

Status & tagging log