r76810 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r76809‎ | r76810 | r76811 >
Date:17:44, 16 November 2010
Author:platonides
Status:ok
Tags:
Comment:
The default value of isPermaLink is true, not including it does nothing.
http://www.rssboard.org/rss-specification#ltguidgtSubelementOfLtitemgt
Modified paths:
  • /trunk/phase3/includes/Feed.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Feed.php
@@ -305,7 +305,7 @@
306306 <item>
307307 <title><?php print $item->getTitle() ?></title>
308308 <link><?php print $item->getUrl() ?></link>
309 - <guid<?php if( $item->RSSIsPermalink ) print ' isPermaLink="true"' ?>><?php print $item->getUniqueId() ?></guid>
 309+ <guid<?php if( !$item->RSSIsPermalink ) print ' isPermaLink="false"' ?>><?php print $item->getUniqueId() ?></guid>
310310 <description><?php print $item->getDescription() ?></description>
311311 <?php if( $item->getDate() ) { ?><pubDate><?php print $this->formatTime( $item->getDate() ) ?></pubDate><?php } ?>
312312 <?php if( $item->getAuthor() ) { ?><dc:creator><?php print $item->getAuthor() ?></dc:creator><?php }?>

Status & tagging log