r76809 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r76808‎ | r76809 | r76810 >
Date:16:54, 16 November 2010
Author:maxsem
Status:ok (Comments)
Tags:
Comment:
Follow-up r76805: removed outdated comment, introduced new group "Search"
Modified paths:
  • /trunk/phase3/maintenance/tests/phpunit/includes/search/SearchDbTest.php (modified) (history)
  • /trunk/phase3/maintenance/tests/phpunit/includes/search/SearchEngineTest.php (modified) (history)
  • /trunk/phase3/maintenance/tests/phpunit/includes/search/SearchUpdateTest.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/tests/phpunit/includes/search/SearchDbTest.php
@@ -3,7 +3,7 @@
44 require_once( dirname( __FILE__ ) . '/SearchEngineTest.php' );
55
66 /**
7 - * @group Database
 7+ * @group Search
88 * @group Destructive
99 */
1010 class SearchDbTest extends SearchEngineTest {
Index: trunk/phase3/maintenance/tests/phpunit/includes/search/SearchEngineTest.php
@@ -4,6 +4,7 @@
55
66 /**
77 * This class is not directly tested. Instead it is extended by SearchDbTest.
 8+ * @group Search
89 * @group Stub
910 * @group Destructive
1011 */
Index: trunk/phase3/maintenance/tests/phpunit/includes/search/SearchUpdateTest.php
@@ -16,8 +16,7 @@
1717 }
1818
1919 /**
20 - * Disabled until we're able to run it without messing with LoadBalancer and breaking
21 - * other tests in a sneaky way
 20+ * @group Search
2221 */
2322 class SearchUpdateTest extends PHPUnit_Framework_TestCase {
2423 static $searchType;

Follow-up revisions

RevisionCommit summaryAuthorDate
r77109Move storing of $db down to SearchEngine...platonides16:08, 22 November 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r76805Fixed SearchUpdateTest, it doesn't mess with database anymore. More fixes in ...maxsem16:06, 16 November 2010

Comments

#Comment by Platonides (talk | contribs)   17:31, 16 November 2010

It still uses the database, you shouldn't remove it from Database group.

#Comment by MaxSem (talk | contribs)   17:32, 16 November 2010

My understanding is that Database group is for testing database-related stuff, not for anything that may use database.

#Comment by Platonides (talk | contribs)   17:34, 16 November 2010

Well, I intended it to mean 'This test needs a database'. If you come with a better name, it can be renamed.

Status & tagging log