r76752 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r76751‎ | r76752 | r76753 >
Date:01:24, 16 November 2010
Author:kaldari
Status:deferred
Tags:
Comment:
testing
Modified paths:
  • /trunk/extensions/DonationInterface/payflowpro_gateway/forms/TwoStepTwoColumn.php (modified) (history)
  • /trunk/extensions/DonationInterface/payflowpro_gateway/forms/TwoStepTwoColumnLetter3.php (modified) (history)
  • /trunk/extensions/DonationInterface/payflowpro_gateway/forms/css/TwoStepTwoColumnLetter3.css (modified) (history)
  • /trunk/extensions/DonationInterface/payflowpro_gateway/payflowpro_gateway.i18n.php (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/payflowpro_gateway/forms/TwoStepTwoColumn.php
@@ -10,6 +10,11 @@
1111 // we only want to load this JS if the form is being rendered
1212 $this->loadValidateJs(); // validation JS
1313
 14+ $this->loadPlaceholders();
 15+ }
 16+
 17+ public function loadPlaceholders() {
 18+ global $wgOut;
1419 // form placeholder values
1520 $first = wfMsg( 'payflowpro_gateway-first' );
1621 $last = wfMsg( 'payflowpro_gateway-last' );
@@ -33,7 +38,7 @@
3439 EOT;
3540 $wgOut->addHeadItem( 'placeholders', $js );
3641 }
37 -
 42+
3843 /**
3944 * Required method for constructing the entire form
4045 *
Index: trunk/extensions/DonationInterface/payflowpro_gateway/forms/TwoStepTwoColumnLetter3.php
@@ -129,15 +129,15 @@
130130 // card number
131131 $form .= $this->getCardNumberField();
132132
133 - // cvv
134 - $form .= $this->getCvvField();
135 -
136133 // expiry
137134 $form .= '<tr>';
138135 $form .= '<td class="label">' . Xml::label( wfMsg( 'payflowpro_gateway-donor-expiration' ), 'expiration' ) . '</td>';
139136 $form .= '<td>' . $this->generateExpiryMonthDropdown() . ' / ' . $this->generateExpiryYearDropdown() . '</td>';
140137 $form .= '</tr>';
141138
 139+ // cvv
 140+ $form .= $this->getCvvField();
 141+
142142 // name
143143 $form .= '<tr>';
144144 $form .= '<td colspan=2><span class="creditcard-error-msg">' . $this->form_errors['fname'] . '</span></td>';
@@ -152,7 +152,14 @@
153153 $form .= "</tr>";
154154
155155 // email
156 - $form .= $this->getEmailField();
 156+ $form .= '<tr>';
 157+ $form .= '<td colspan=2><span class="creditcard-error-msg">' . $this->form_errors['emailAdd'] . '</span></td>';
 158+ $form .= '</tr>';
 159+ $form .= '<tr>';
 160+ $form .= '<td class="label">' . Xml::label( wfMsg( 'payflowpro_gateway-email-receipt' ), 'emailAdd' ) . '</td>';
 161+ $form .= '<td>' . Xml::input( 'emailAdd', '30', $this->form_data['email'], array( 'type' => 'text', 'onfocus' => 'clearField( this, \''.wfMsg( 'payflowpro_gateway-donor-email' ).'\' )', 'maxlength' => '64', 'id' => 'emailAdd', 'class' => 'fullwidth' ) ) .
 162+ '</td>';
 163+ $form .= '</tr>';
157164
158165 // street
159166 $form .= $this->getStreetField();
@@ -162,6 +169,7 @@
163170
164171 // state
165172 $form .= $this->getStateField();
 173+
166174 // zip
167175 $form .= $this->getZipField();
168176
Index: trunk/extensions/DonationInterface/payflowpro_gateway/forms/css/TwoStepTwoColumnLetter3.css
@@ -101,6 +101,11 @@
102102 margin-bottom:1em;
103103 }
104104
 105+/* Move the form up */
 106+#mw-head-base {
 107+ height: 1em !important;
 108+}
 109+
105110 /* Hiding content border */
106111 table {
107112 background-color: transparent;
Index: trunk/extensions/DonationInterface/payflowpro_gateway/payflowpro_gateway.i18n.php
@@ -198,6 +198,7 @@
199199 'payflowpro_gateway-please-complete' => 'Please complete your donation below ...',
200200 'payflowpro_gateway-description' => 'Description',
201201 'payflowpro_gateway-donation' => 'Donation',
 202+ 'payflowpro_gateway-email-receipt' => 'Email receipt to',
202203
203204 // For more USA states, see payflowpro_gateway.us-states.i18n.php.
204205 'payflowpro_gateway-state-dropdown-YY' => 'Select a State',
@@ -291,6 +292,7 @@
292293 'payflowpro_gateway-continue' => '{{Identical|Continue}}',
293294 'payflowpro_gateway-cancel' => '{{Identical|Cancel}}',
294295 'payflowpro_gateway-month' => 'Expiration month for credit card. $1 is the month number, $2 is the month name.',
 296+ 'payflowpro_gateway-email-receipt' => "Label for field which contains the email address the donor's receipt will be mailed to.",
295297 );
296298
297299 /** Magyar (magázó) (Magyar (magázó))

Follow-up revisions

RevisionCommit summaryAuthorDate
r76785Follow-up r76752: Email -> E-mail for consistencyraymond07:22, 16 November 2010

Status & tagging log