r76703 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r76702‎ | r76703 | r76704 >
Date:20:40, 15 November 2010
Author:platonides
Status:deferred (Comments)
Tags:
Comment:
If this was needed to use MockSearch, it will also be needed after it has run, so other tests can get the real db they expect.
Modified paths:
  • /trunk/phase3/maintenance/tests/phpunit/includes/search/SearchUpdateTest.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/tests/phpunit/includes/search/SearchUpdateTest.php
——@@ -91,6 +91,8 @@
9292 $wgDBtype = self::$dbtype;
9393 $wgLBFactoryConf = self::$factoryconf;
9494 $wgDBservers = self::$dbservers;
 95+
 96+ wfGetLBFactory()->destroyInstance();
9597 }
9698
9799 function testUpdateText() {

Comments

#Comment by MaxSem (talk | contribs)   20:44, 15 November 2010

The whole test is currently disabled because just this call causes fatals later because DB connections are sometimes saved. This test needs a rewrite.

#Comment by Platonides (talk | contribs)   21:08, 15 November 2010

It passes here. Where are you seeing the fatals?

#Comment by MaxSem (talk | contribs)   10:18, 16 November 2010

On Tesla. On my box it passes too.

#Comment by Platonides (talk | contribs)   16:31, 16 November 2010

Tesla setup is odd. Not too reliable if it can't be replicated.

#Comment by MaxSem (talk | contribs)   16:35, 16 November 2010

In any case, after r76805 this test doesn't mess with database anymore.

Status & tagging log