r76567 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r76566‎ | r76567 | r76568 >
Date:07:47, 12 November 2010
Author:bawolff
Status:ok (Comments)
Tags:
Comment:
Follow up r76566 (Bug 25872) - rename HttpRequest class to avoid conflicts with php extension.

Rename it in extensions that i'm aware of that use it.
Modified paths:
  • /trunk/extensions/Translate/utils/TranslationHelpers.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/utils/TranslationHelpers.php
@@ -449,7 +449,13 @@
450450 $url = wfExpandUrl( $url );
451451
452452 $options['method'] = 'GET';
453 - $req = HttpRequest::factory( $url, $options );
 453+
 454+ if ( class_exists( 'MWHttpRequest' ) ) {
 455+ $req = MWHttpRequest::factory( $url, $options );
 456+ } else {
 457+ $req = HttpRequest::factory( $url, $options );
 458+ }
 459+
454460 $status = $req->execute();
455461
456462 if ( !$status->isOK() ) {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r76566(Bug 25872) Rename HttpRequest class to MWHttpRequest to avoid conflict with ...bawolff07:32, 12 November 2010

Comments

#Comment by Nikerabbit (talk | contribs)   08:30, 12 November 2010

BC is good!

Status & tagging log