r76561 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r76560‎ | r76561 | r76562 >
Date:01:54, 12 November 2010
Author:kaldari
Status:deferred
Tags:
Comment:
new 2-step form for Friday
Modified paths:
  • /trunk/extensions/DonationInterface/payflowpro_gateway/forms/Form.php (modified) (history)
  • /trunk/extensions/DonationInterface/payflowpro_gateway/forms/TwoStepTwoColumn.php (modified) (history)
  • /trunk/extensions/DonationInterface/payflowpro_gateway/forms/css/TwoColumnLetter5.css (modified) (history)
  • /trunk/extensions/DonationInterface/payflowpro_gateway/forms/css/TwoColumnLetter6.css (modified) (history)
  • /trunk/extensions/DonationInterface/payflowpro_gateway/payflowpro_gateway.i18n.php (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/payflowpro_gateway/forms/TwoStepTwoColumn.php
@@ -118,7 +118,7 @@
119119 protected function generatePersonalContainer() {
120120 $form = '';
121121 $form .= Xml::openElement( 'div', array( 'id' => 'payflowpro_gateway-personal-info' ) ); ;
122 - $form .= Xml::tags( 'h3', array( 'class' => 'payflow-cc-form-header', 'id' => 'payflow-cc-form-header-personal' ), wfMsg( 'payflowpro_gateway-cc-form-header-personal' ) );
 122+ //$form .= Xml::tags( 'h3', array( 'class' => 'payflow-cc-form-header', 'id' => 'payflow-cc-form-header-personal' ), wfMsg( 'payflowpro_gateway-cc-form-header-personal' ) );
123123 $form .= Xml::openElement( 'table', array( 'id' => 'payflow-table-donor' ) );
124124
125125 $form .= $this->generatePersonalFields();
@@ -159,7 +159,7 @@
160160 $form = '';
161161 // credit card info
162162 $form .= Xml::openElement( 'div', array( 'id' => 'payflowpro_gateway-payment-info' ) );
163 - $form .= Xml::tags( 'h3', array( 'class' => 'payflow-cc-form-header', 'id' => 'payflow-cc-form-header-payment' ), wfMsg( 'payflowpro_gateway-cc-form-header-payment' ) );
 163+ //$form .= Xml::tags( 'h3', array( 'class' => 'payflow-cc-form-header', 'id' => 'payflow-cc-form-header-payment' ), wfMsg( 'payflowpro_gateway-cc-form-header-payment' ) );
164164 $form .= Xml::openElement( 'table', array( 'id' => 'payflow-table-cc' ) );
165165
166166 $form .= $this->generatePaymentFields();
Index: trunk/extensions/DonationInterface/payflowpro_gateway/forms/css/TwoColumnLetter5.css
@@ -105,6 +105,9 @@
106106 input.fullwidth {
107107 width:300px !important;
108108 }
 109+#footer {
 110+ background-image: none !important;
 111+}
109112
110113 div#payflowpro_gateway-form-submit-paypal {
111114 display: none;
Index: trunk/extensions/DonationInterface/payflowpro_gateway/forms/css/TwoColumnLetter6.css
@@ -115,6 +115,9 @@
116116 table#payflow-table-cc {
117117 display: none;
118118 }
 119+#footer {
 120+ background-image: none !important;
 121+}
119122
120123 /* Hiding stuff we don't need */
121124 h1#firstHeading, div#contentSub {
Index: trunk/extensions/DonationInterface/payflowpro_gateway/forms/Form.php
@@ -110,10 +110,10 @@
111111 $form = '';
112112 $form .= Xml::openElement( 'div', array( 'class' => 'payflow-cc-form-section', 'id' => 'payflowpro_gateway-donate-addl-info' ) );
113113 $form .= Xml::openElement( 'div', array( 'id' => 'payflowpro_gateway-donate-addl-info-secure-logos' ) );
114 - $form .= Xml::tags( 'p', array( 'class' => '' ), Xml::openElement( 'img', array( 'src' => $wgScriptPath . "/extensions/DonationInterface/payflowpro_gateway/includes/rapidssl_ssl_certificate.gif" ) ) );
 114+ $form .= Xml::tags( 'p', array( 'class' => '' ), Xml::openElement( 'img', array( 'src' => $wgScriptPath . "/extensions/DonationInterface/payflowpro_gateway/includes/rapidssl_ssl_certificate-nonanimated.png" ) ) );
115115 $form .= Xml::closeElement( 'div' ); // close div#payflowpro_gateway-donate-addl-info-secure-logos
116116 $form .= Xml::openElement( 'div', array( 'id' => 'payflowpro_gateway-donate-addl-info-text' ) );
117 - $form .= Xml::tags( 'p', array( 'class' => '' ), wfMsg( 'payflowpro_gateway-otherways' ) );
 117+ $form .= Xml::tags( 'p', array( 'class' => '' ), wfMsg( 'payflowpro_gateway-otherways-short' ) );
118118 $form .= Xml::tags( 'p', array( 'class' => '' ), wfMsg( 'payflowpro_gateway-credit-storage-processing' ) );
119119 $form .= Xml::tags( 'p', array( 'class' => '' ), wfMsg( 'payflowpro_gateway-question-comment' ) );
120120 $form .= Xml::closeElement( 'div' ); // close div#payflowpro_gateway-donate-addl-info-text
Index: trunk/extensions/DonationInterface/payflowpro_gateway/payflowpro_gateway.i18n.php
@@ -10,7 +10,7 @@
1111
1212 /** English */
1313 $messages['en'] = array(
14 - 'payflowprogateway' => 'Support Wikipedia with your secure donation',
 14+ 'payflowprogateway' => 'Make your donation now',
1515 'payflowpro_gateway-desc' => 'PayPal Payflow Pro credit card processing',
1616 'payflowpro_gateway-accessible' => 'This page is only accessible from the donation page.',
1717 'payflowpro_gateway-form-message' => 'Use the form below to donate with a credit card, or ',

Follow-up revisions

RevisionCommit summaryAuthorDate
r76562Merging from r76557 thru r76561 of trunkawjrichards02:03, 12 November 2010

Status & tagging log