r76551 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r76550‎ | r76551 | r76552 >
Date:00:14, 12 November 2010
Author:kaldari
Status:deferred
Tags:
Comment:
fixing global var
Modified paths:
  • /trunk/extensions/LandingCheck/LandingCheck.php (modified) (history)
  • /trunk/extensions/LandingCheck/SpecialLandingCheck.php (modified) (history)

Diff [purge]

Index: trunk/extensions/LandingCheck/LandingCheck.php
@@ -21,7 +21,7 @@
2222
2323 // If there are any countries for which the country page should be the fallback rather than a
2424 // language page, add its country code to this array.
25 -$priorityCountries = array();
 25+$wgPriorityCountries = array();
2626
2727 $dir = dirname( __FILE__ ) . '/';
2828
Index: trunk/extensions/LandingCheck/SpecialLandingCheck.php
@@ -17,7 +17,7 @@
1818 }
1919
2020 public function execute( $sub ) {
21 - global $wgOut, $wgRequest, $priorityCountries;
 21+ global $wgOut, $wgRequest, $wgPriorityCountries;
2222
2323 // Pull in query string parameters
2424 $language = $wgRequest->getVal( 'language', 'en' );
@@ -32,7 +32,7 @@
3333 'referrer' => $wgRequest->getHeader( 'referer' )
3434 ) );
3535
36 - if ( in_array( $country, $priorityCountries ) ) {
 36+ if ( in_array( $country, $wgPriorityCountries ) ) {
3737 // Build array of landing pages to check for
3838 $targetTexts = array(
3939 $landingPage . '/' . $country . '/' . $language,

Follow-up revisions

RevisionCommit summaryAuthorDate
r76552Merging in r76551tomasz00:25, 12 November 2010

Status & tagging log