r76474 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r76473‎ | r76474 | r76475 >
Date:21:23, 10 November 2010
Author:catrope
Status:ok
Tags:
Comment:
Fix parse error in r76471
Modified paths:
  • /branches/wmf/1.16wmf4/extensions/UsabilityInitiative/Vector/Modules/CollapsibleTabs/CollapsibleTabs.js (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/UsabilityInitiative/Vector/Vector.combined.js (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/UsabilityInitiative/Vector/Vector.combined.min.js (modified) (history)

Diff [purge]

Index: branches/wmf/1.16wmf4/extensions/UsabilityInitiative/Vector/Modules/CollapsibleTabs/CollapsibleTabs.js
@@ -82,7 +82,6 @@
8383 return;
8484 }
8585 expContainerSettings.shifting = false;
86 - .shifting = false;
8786 $j.collapsibleTabs.handleResize();
8887 } ) );
8988 };
Index: branches/wmf/1.16wmf4/extensions/UsabilityInitiative/Vector/Vector.combined.js
@@ -301,7 +301,6 @@
302302 return;
303303 }
304304 expContainerSettings.shifting = false;
305 - .shifting = false;
306305 $j.collapsibleTabs.handleResize();
307306 } ) );
308307 };
Index: branches/wmf/1.16wmf4/extensions/UsabilityInitiative/Vector/Vector.combined.min.js
@@ -20,7 +20,7 @@
2121 var expContainerSettings=$j.collapsibleTabs.getSettings($j(data.expandedContainer));if(!expContainerSettings){return;}
2222 expContainerSettings.shifting=true;var $target=$j(data.expandedContainer).find('span.placeholder:first');var expandedWidth=data.expandedWidth;$moving.css("position","relative").css((rtl?'right':'left'),0).css('width','1px');$target.replaceWith($moving.remove().css('width','1px').data('collapsibleTabsSettings',data).animate({width:expandedWidth+"px"},"normal",function(){$j(this).attr('style','display:block;');var data=$j.collapsibleTabs.getSettings($j(ele));if(!data){return;}
2323 var expContainerSettings=$j.collapsibleTabs.getSettings($j(data.expandedContainer));if(!expContainerSettings){return;}
24 -expContainerSettings.shifting=false;.shifting=false;$j.collapsibleTabs.handleResize();}));};$j('#p-views ul').bind("beforeTabCollapse",function(){if($j('#p-cactions').css('display')=='none')
 24+expContainerSettings.shifting=false;$j.collapsibleTabs.handleResize();}));};$j('#p-views ul').bind("beforeTabCollapse",function(){if($j('#p-cactions').css('display')=='none')
2525 $j("#p-cactions").addClass("filledPortlet").removeClass("emptyPortlet").find('h5').css('width','1px').animate({'width':'26px'},390);}).bind("beforeTabExpand",function(){if($j('#p-cactions li').length==1)
2626 $j("#p-cactions h5").animate({'width':'1px'},370,function(){$j(this).attr('style','').parent().addClass("emptyPortlet").removeClass("filledPortlet");});}).collapsibleTabs({expandCondition:function(eleWidth){if(rtl){return($j('#right-navigation').position().left+$j('#right-navigation').width()+1)<($j('#left-navigation').position().left-eleWidth);}else{return($j('#left-navigation').position().left+$j('#left-navigation').width()+1)<($j('#right-navigation').position().left-eleWidth);}},collapseCondition:function(){if(rtl){return($j('#right-navigation').position().left+$j('#right-navigation').width())>$j('#left-navigation').position().left;}else{return($j('#left-navigation').position().left+$j('#left-navigation').width())>$j('#right-navigation').position().left;}}});});$j(document).ready(function(){if(!wgVectorEnabledModules.editwarning||$j('#wpTextbox1').size()==0){return true;}
2727 $j('#wpTextbox1, #wpSummary').each(function(){$j(this).data('origtext',$j(this).val());});var fallbackWindowOnBeforeUnload=window.onbeforeunload;var ourWindowOnBeforeUnload=function(){var fallbackResult=undefined;var retval=undefined;var thisFunc=arguments.callee;if(fallbackWindowOnBeforeUnload){fallbackResult=fallbackWindowOnBeforeUnload();}

Follow-up revisions

RevisionCommit summaryAuthorDate
r76628Merge live hacks from 1.16wmf4: r76467, r76469, r76471, r76474catrope16:32, 13 November 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r764711.16wmf4: More live hacking, hoping to really fix it this timecatrope21:11, 10 November 2010

Status & tagging log