r76430 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r76429‎ | r76430 | r76431 >
Date:05:56, 10 November 2010
Author:awjrichards
Status:deferred
Tags:
Comment:
Merging from r76427 thru r76429 of trunk
Modified paths:
  • /branches/fundraising/deployment/DonationInterface (modified) (history)
  • /branches/fundraising/deployment/DonationInterface/payflowpro_gateway/payflowpro_gateway.body.php (modified) (history)
  • /branches/fundraising/deployment/DonationInterface/payflowpro_gateway/payflowpro_gateway.php (modified) (history)

Diff [purge]

Index: branches/fundraising/deployment/DonationInterface/payflowpro_gateway/payflowpro_gateway.body.php
@@ -157,7 +157,9 @@
158158 $this->fnPayflowDisplayForm( $data, $this->errors );
159159 } else { // The submitted form data is valid, so process it
160160 // allow any external validators to have their way with the data
 161+ wfDebugLog( 'payflowpro_gateway', 'Preparing to query MaxMind' );
161162 wfRunHooks( 'PayflowGatewayValidate', array( &$this, &$data ) );
 163+ wfDebugLog( 'payflowpro_gateway', 'Finished querying Maxmind' );
162164
163165 // if the transaction was flagged for review
164166 if ( $this->action == 'review' ) {
@@ -448,12 +450,15 @@
449451 $i = 1;
450452
451453 while ( $i++ <= 3 ) {
 454+ wfDebugLog( 'payflowpro_gateway', 'Preparing to send transaction to PayflowPro' );
452455 $result = curl_exec( $ch );
453456 $headers = curl_getinfo( $ch );
454457
455458 if ( $headers['http_code'] != 200 && $headers['http_code'] != 403 ) {
 459+ wfDebugLog( 'payflowpro_gateway', 'Failed sending transaction to PayflowPro, retrying' );
456460 sleep( 5 );
457461 } elseif ( $headers['http_code'] == 200 || $headers['http_code'] == 403 ) {
 462+ wfDebugLog( 'payflowpro_gateway', 'Finished sending transaction to PayflowPro' );
458463 break;
459464 }
460465 }
Index: branches/fundraising/deployment/DonationInterface/payflowpro_gateway/payflowpro_gateway.php
@@ -55,7 +55,7 @@
5656 $wgPayflowGatewayTest = FALSE;
5757
5858 // timeout in seconds for communicating with paypal
59 -$wgPayflowProTimeout = 2;
 59+$wgPayflowProTimeout = 5;
6060
6161 /**
6262 * The default form to use
Property changes on: branches/fundraising/deployment/DonationInterface
___________________________________________________________________
Modified: svn:mergeinfo
6363 Merged /trunk/extensions/DonationInterface:r76427-76429

Follow-up revisions

RevisionCommit summaryAuthorDate
r76432Merging from r76430 to r76431 of trunkawjrichards05:58, 10 November 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r76427Merging from r76410 through r76426 of trunkawjrichards04:03, 10 November 2010
r76429Added some debug logging; Increased default paypal timeout limitawjrichards05:54, 10 November 2010

Status & tagging log