r76392 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r76391‎ | r76392 | r76393 >
Date:17:00, 9 November 2010
Author:ialex
Status:resolved (Comments)
Tags:
Comment:
* (bug 17789) Added a note to the total views on Special:Statistics saying that is doesn't count non-existing pages and special pages
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/specials/SpecialStatistics.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)
  • /trunk/phase3/maintenance/language/messages.inc (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/language/messages.inc
@@ -1473,6 +1473,7 @@
14741474 'statistics-edits',
14751475 'statistics-edits-average',
14761476 'statistics-views-total',
 1477+ 'statistics-views-total-desc'
14771478 'statistics-views-peredit',
14781479 'statistics-users',
14791480 'statistics-users-active',
Index: trunk/phase3/RELEASE-NOTES
@@ -412,6 +412,8 @@
413413 normalised like normal links to special pages
414414 * (bug 21364) External links using link= attribute on images now respect
415415 $wgExternalLinkTarget
 416+* (bug 17789) Added a note to the total views on Special:Statistics saying that
 417+ is doesn't count non-existing pages and special pages
416418
417419 === API changes in 1.17 ===
418420 * (bug 22738) Allow filtering by action type on query=logevent.
Index: trunk/phase3/includes/specials/SpecialStatistics.php
@@ -187,6 +187,7 @@
188188 'statistics-users-active-desc',
189189 $wgLang->formatNum( $wgActiveUserDays ) );
190190 }
 191+
191192 private function getGroupStats() {
192193 global $wgGroupPermissions, $wgImplicitGroups, $wgLang, $wgUser;
193194 $sk = $wgUser->getSkin();
@@ -233,6 +234,7 @@
234235 }
235236 return $text;
236237 }
 238+
237239 private function getViewsStats() {
238240 global $wgLang;
239241 return Xml::openElement( 'tr' ) .
@@ -240,12 +242,13 @@
241243 Xml::closeElement( 'tr' ) .
242244 $this->formatRow( wfMsgExt( 'statistics-views-total', array( 'parseinline' ) ),
243245 $wgLang->formatNum( $this->views ),
244 - array ( 'class' => 'mw-statistics-views-total' ) ) .
 246+ array ( 'class' => 'mw-statistics-views-total' ), 'statistics-views-total-desc' ) .
245247 $this->formatRow( wfMsgExt( 'statistics-views-peredit', array( 'parseinline' ) ),
246248 $wgLang->formatNum( sprintf( '%.2f', $this->edits ?
247249 $this->views / $this->edits : 0 ) ),
248250 array ( 'class' => 'mw-statistics-views-peredit' ) );
249251 }
 252+
250253 private function getMostViewedPages() {
251254 global $wgLang, $wgUser;
252255 $text = '';
@@ -284,7 +287,7 @@
285288 }
286289 return $text;
287290 }
288 -
 291+
289292 private function getOtherStats( $stats ) {
290293 global $wgLang;
291294
Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -2382,6 +2382,7 @@
23832383 'statistics-edits' => 'Page edits since {{SITENAME}} was set up',
23842384 'statistics-edits-average' => 'Average edits per page',
23852385 'statistics-views-total' => 'Views total',
 2386+'statistics-views-total-desc' => 'Views to non-existing pages and special pages are not included',
23862387 'statistics-views-peredit' => 'Views per edit',
23872388 'statistics-users' => 'Registered [[Special:ListUsers|users]]',
23882389 'statistics-users-active' => 'Active users',

Follow-up revisions

RevisionCommit summaryAuthorDate
r76408Fix syntax error from r76392ialex19:52, 9 November 2010

Comments

#Comment by Happy-melon (talk | contribs)   23:58, 14 December 2010

Guess this isn't "ok" in itself, but it's "resolved" by r76408.

Status & tagging log