r76245 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r76244‎ | r76245 | r76246 >
Date:13:12, 7 November 2010
Author:catrope
Status:deferred
Tags:
Comment:
uploadwizard-deployment: Merge r76175, r76177, r76186 from trunk
Modified paths:
  • /branches/uploadwizard-deployment/includes/AutoLoader.php (modified) (history)
  • /branches/uploadwizard-deployment/includes/specials/SpecialUploadStash.php (modified) (history)

Diff [purge]

Index: branches/uploadwizard-deployment/includes/AutoLoader.php
@@ -597,11 +597,16 @@
598598 'UserloginTemplate' => 'includes/templates/Userlogin.php',
599599
600600 # includes/upload
601 - 'UploadStash' => 'includes/upload/UploadStash.php',
602601 'UploadBase' => 'includes/upload/UploadBase.php',
603602 'UploadFromStash' => 'includes/upload/UploadFromStash.php',
604603 'UploadFromFile' => 'includes/upload/UploadFromFile.php',
605604 'UploadFromUrl' => 'includes/upload/UploadFromUrl.php',
 605+ 'UploadStash' => 'includes/upload/UploadStash.php',
 606+ 'UploadStashNotAvailableException' => 'includes/upload/UploadStash.php',
 607+ 'UploadStashFileNotFoundException' => 'includes/upload/UploadStash.php',
 608+ 'UploadStashBadPathException' => 'includes/upload/UploadStash.php',
 609+ 'UploadStashBadVersionException' => 'includes/upload/UploadStash.php',
 610+ 'UploadStashFileException' => 'includes/upload/UploadStash.php',
606611
607612 # languages
608613 'Language' => 'languages/Language.php',
Property changes on: branches/uploadwizard-deployment/includes/AutoLoader.php
___________________________________________________________________
Modified: svn:mergeinfo
609614 Merged /trunk/phase3/includes/AutoLoader.php:r76186
Index: branches/uploadwizard-deployment/includes/specials/SpecialUploadStash.php
@@ -113,8 +113,8 @@
114114 // ok we're here so the original must exist. Generate the thumbnail.
115115 // because the file is a UploadStashFile, this thumbnail will also be stashed,
116116 // and a thumbnailFile will be created in the thumbnailImage composite object
117 - $thumbnailImage = null;
118 - if ( !( $thumbnailImage = $origFile->getThumbnail( $width ) ) ) {
 117+ $thumbnailImage = $origFile->transform( array( 'width' => $width ) );
 118+ if ( !$thumbnailImage ) {
119119 throw new MWException( 'Could not obtain thumbnail' );
120120 }
121121 $file = $thumbnailImage->thumbnailFile;
Property changes on: branches/uploadwizard-deployment/includes/specials/SpecialUploadStash.php
___________________________________________________________________
Modified: svn:mergeinfo
122122 Merged /trunk/phase3/includes/specials/SpecialUploadStash.php:r76175,76177,76186

Follow-up revisions

RevisionCommit summaryAuthorDate
r76246uploadwizard-deploy: Merge UploadWizard extension to trunk state (r76245)catrope13:14, 7 November 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r76175Do not assign the variable in the condition....platonides00:18, 6 November 2010
r76177UploadStashFileNotFoundException and UploadStashBadPathException are defined ...platonides00:23, 6 November 2010
r76186Revert r76177 and use AutoLoadercatrope11:52, 6 November 2010

Status & tagging log