r76192 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r76191‎ | r76192 | r76193 >
Date:15:11, 6 November 2010
Author:reedy
Status:reverted (Comments)
Tags:
Comment:
Update all remaining Xml::hidden to Html::hidden in extensions
Modified paths:
  • /trunk/extensions/APC/APCCacheMode.php (modified) (history)
  • /trunk/extensions/AdvancedSearch/AdvancedSearch.body.php (modified) (history)
  • /trunk/extensions/BadImage/BadImage.page.php (modified) (history)
  • /trunk/extensions/ChangeAuthor/ChangeAuthor.body.php (modified) (history)
  • /trunk/extensions/CloseWikis/CloseWikis.page.php (modified) (history)
  • /trunk/extensions/Configure/specials/ConfigurationPage.php (modified) (history)
  • /trunk/extensions/Configure/specials/SpecialViewConfig.php (modified) (history)
  • /trunk/extensions/ConfigureWMF/ConfigureWMF.page.php (modified) (history)
  • /trunk/extensions/ConfirmAccount/ConfirmAccount_body.php (modified) (history)
  • /trunk/extensions/ConfirmAccount/RequestAccount_body.php (modified) (history)
  • /trunk/extensions/ConfirmAccount/UserCredentials_body.php (modified) (history)
  • /trunk/extensions/Contributors/Contributors.page.php (modified) (history)
  • /trunk/extensions/Crosswiki/Block/CrosswikiBlock.page.php (modified) (history)
  • /trunk/extensions/DeleteBatch/DeleteBatch.body.php (modified) (history)
  • /trunk/extensions/DeleteQueue/Views/DeleteQueueViewList.php (modified) (history)
  • /trunk/extensions/DeleteQueue/Views/DeleteQueueViewNominate.php (modified) (history)
  • /trunk/extensions/DeleteQueue/Views/DeleteQueueViewReview.php (modified) (history)
  • /trunk/extensions/DeleteQueue/Views/DeleteQueueViewVote.php (modified) (history)
  • /trunk/extensions/Deployment/includes/filesystems/Ssh2Filesystem.php (modified) (history)
  • /trunk/extensions/Duplicator/Duplicator.page.php (modified) (history)
  • /trunk/extensions/Farmer/SpecialFarmer.php (modified) (history)
  • /trunk/extensions/FlagPage/FlagPage.body.php (modified) (history)
  • /trunk/extensions/IndexFunction/SpecialIndex.php (modified) (history)
  • /trunk/extensions/Interwiki/Interwiki_body.php (modified) (history)
  • /trunk/extensions/InterwikiIntegration/SpecialInterwikiWatchlist.php (modified) (history)
  • /trunk/extensions/InterwikiList/InterwikiList_body.php (modified) (history)
  • /trunk/extensions/Invitations/Invitations_page.php (modified) (history)
  • /trunk/extensions/LanguageSelector/LanguageSelector.php (modified) (history)
  • /trunk/extensions/Maps/compat/Html.php (modified) (history)
  • /trunk/extensions/MassBlank/MassBlank_body.php (modified) (history)
  • /trunk/extensions/MetavidWiki/includes/MV_MetavidInterface/MV_EditPageAjax.php (modified) (history)
  • /trunk/extensions/MostRevisors/MostRevisors_body.php (modified) (history)
  • /trunk/extensions/MultiBoilerplate/MultiBoilerplate.php (modified) (history)
  • /trunk/extensions/MultilingualLiquidThreads/LiquidThreads/classes/View.php (modified) (history)
  • /trunk/extensions/MultilingualLiquidThreads/LiquidThreads/compat/HTMLForm.php (modified) (history)
  • /trunk/extensions/MultilingualLiquidThreads/LiquidThreads/pages/NewUserMessagesView.php (modified) (history)
  • /trunk/extensions/MultilingualLiquidThreads/LiquidThreads/pages/SpecialMergeThread.php (modified) (history)
  • /trunk/extensions/MultilingualLiquidThreads/LiquidThreads/pages/TalkpageView.php (modified) (history)
  • /trunk/extensions/NewestPages/NewestPages.page.php (modified) (history)
  • /trunk/extensions/NssMySQLAuth/SpecialAccountManager.php (modified) (history)
  • /trunk/extensions/OpenID/SpecialOpenIDConvert.body.php (modified) (history)
  • /trunk/extensions/PasswordReset/PasswordReset_body.php (modified) (history)
  • /trunk/extensions/Patroller/Patroller.class.php (modified) (history)
  • /trunk/extensions/Poll/Poll_body.php (modified) (history)
  • /trunk/extensions/PrefSwitch/SpecialPrefSwitch.php (modified) (history)
  • /trunk/extensions/Preview/Preview.php (modified) (history)
  • /trunk/extensions/RDFIO/specials/SpecialARC2Admin_body.php (modified) (history)
  • /trunk/extensions/RDFIO/specials/SpecialRDFImport_body.php (modified) (history)
  • /trunk/extensions/RDFIO/specials/SpecialSPARQLEndpoint_body.php (modified) (history)
  • /trunk/extensions/RandomInCategory/RandomInCategory.body.php (modified) (history)
  • /trunk/extensions/RefHelper/RefHelper.create.php (modified) (history)
  • /trunk/extensions/RefHelper/RefHelper.search.php (modified) (history)
  • /trunk/extensions/ReplaceText/SpecialReplaceText.php (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/compat/Html.php (modified) (history)
  • /trunk/extensions/SharedUserRights/SharedUserRights_body.php (modified) (history)
  • /trunk/extensions/SimpleSurvey/SpecialSimpleSurvey.php (modified) (history)
  • /trunk/extensions/SocialProfile/UserProfile/SpecialRemoveAvatar.php (modified) (history)
  • /trunk/extensions/SpamDiffTool/SpamDiffTool_body.php (modified) (history)
  • /trunk/extensions/UserMerge/UserMerge_body.php (modified) (history)
  • /trunk/extensions/Vote/Vote.page.php (modified) (history)
  • /trunk/extensions/WatchSubpages/WatchSubpages_body.php (modified) (history)

Follow-up revisions

RevisionCommit summaryAuthorDate
r77593Reverting r76192 due to 1.15 back compat...reedy17:31, 2 December 2010

Comments

#Comment by Jeroen De Dauw (talk | contribs)   17:03, 7 November 2010

Can you exclude comments when doing a replace like this? Although this is not wrong, the comment is now stating the obvious rather then being helpful :)

r1=75871&r2=76192&pathrev=76192 http://svn.wikimedia.org/viewvc/mediawiki/trunk/extensions/SemanticMediaWiki/compat/Html.php?r1=75871&r2=76192&pathrev=76192

#Comment by Jeroen De Dauw (talk | contribs)   17:04, 7 November 2010
#Comment by Yaron Koren (talk | contribs)   03:09, 2 December 2010

Unfortunately, I only saw this now, but this looks like another candidate for a mass revert. It broke backward compatibility with MediaWiki 1.15, which, as was discussed before, is too early to do; and, as Jeroen noted above, it also pointlessly modified some comments. It would be great if you could revert it, but if not, I plan to revert it tomorrow, unless anyone has a good reason not to.

#Comment by Reedy (talk | contribs)   16:59, 2 December 2010

Back compatability sucks, Added ~4000 revs after 1.15 branching by Aryeh.

Will revert soon.

#Comment by Yaron Koren (talk | contribs)   17:52, 2 December 2010

Thank you.

Status & tagging log