r76064 MediaWiki - Code Review archive

Repository:	MediaWiki
Revision:	< r76063‎ \| r76064 \| r76065 >
Date:	23:55, 4 November 2010
Author:	reedy
Status:	reverted (Comments)
Tags:
Comment:	Kill numerous wfLoadExtensionMessages calls 344 usages left...
Modified paths:	/trunk/extensions/ABC/ABC.php (modified) (history) /trunk/extensions/APC/SpecialAPC.php (modified) (history) /trunk/extensions/AbsenteeLandlord/AbsenteeLandlord.php (modified) (history) /trunk/extensions/AdminLinks/AdminLinks_body.php (modified) (history) /trunk/extensions/AdvancedRandom/AdvancedRandom_body.php (modified) (history) /trunk/extensions/AdvancedSearch/AdvancedSearch.body.php (modified) (history) /trunk/extensions/AdvancedSearch/AdvancedSearch.php (modified) (history) /trunk/extensions/AmazonPlus/AmazonPlus.php (modified) (history) /trunk/extensions/ApprovedRevs/ApprovedRevs.hooks.php (modified) (history) /trunk/extensions/ApprovedRevs/SpecialApprovedRevs.php (modified) (history) /trunk/extensions/ArticleToCategory2/ArticleToCategory2.php (modified) (history) /trunk/extensions/Asksql/Asksql_body.php (modified) (history) /trunk/extensions/Babel/Babel.class.php (modified) (history) /trunk/extensions/Babel/BabelAutoCreate.class.php (modified) (history) /trunk/extensions/BackAndForth/BackAndForth.class.php (modified) (history) /trunk/extensions/BadImage/BadImage.page.php (modified) (history) /trunk/extensions/Blahtex/Blahtex.php (modified) (history) /trunk/extensions/BlockTitles/BlockTitles.php (modified) (history) /trunk/extensions/Call/Call_body.php (modified) (history) /trunk/extensions/CategoryBrowser/CategoryBrowserCtrl.php (modified) (history) /trunk/extensions/CategoryBrowser/CategoryBrowserPage.php (modified) (history) /trunk/extensions/CategoryFeed/CategoryFeed.php (modified) (history) /trunk/extensions/CategoryIntersection/CategoryIntersection_body.php (modified) (history) /trunk/extensions/CategoryMultisort/CategoryMultisort.hooks.php (modified) (history) /trunk/extensions/CategoryMultisortChinese/CategoryMultisortChinese.php (modified) (history) /trunk/extensions/CategoryOnUpload/CategoryOnUpload.php (modified) (history) /trunk/extensions/CategoryStepper/CategoryStepper.php (modified) (history) /trunk/extensions/CategoryWatch/CategoryWatch.php (modified) (history) /trunk/extensions/ChangeAuthor/ChangeAuthor.body.php (modified) (history) /trunk/extensions/Checkpoint/Checkpoint.php (modified) (history) /trunk/extensions/Chemistry/ChemFunctions.php (modified) (history) /trunk/extensions/Chemistry/SpecialChemicalsources_body.php (modified) (history) /trunk/extensions/CleanChanges/CleanChanges_body.php (modified) (history) /trunk/extensions/CleanChanges/Filters.php (modified) (history) /trunk/extensions/CloseWikis/CloseWikis.list.php (modified) (history) /trunk/extensions/CloseWikis/CloseWikis.page.php (modified) (history) /trunk/extensions/CloseWikis/CloseWikis.php (modified) (history) /trunk/extensions/CodeBrowse/SpecialCodeBrowse.php (modified) (history) /trunk/extensions/CommentPages/CommentPages.php (modified) (history) /trunk/extensions/CommentSpammer/CommentSpammer.php (modified) (history) /trunk/extensions/Commentbox/SpecialAddComment_body.php (modified) (history) /trunk/extensions/Configure/Configure.func.php (modified) (history) /trunk/extensions/ConfigureWMF/ConfigureWMF.page.php (modified) (history) /trunk/extensions/Contributionseditcount/Contributionseditcount.php (modified) (history) /trunk/extensions/Contributors/Contributors.php (modified) (history) /trunk/extensions/CooperationStatistics/CooperationStatistics_body.php (modified) (history) /trunk/extensions/CountEdits/CountEdits.page.php (modified) (history) /trunk/extensions/CreateBox/CreateBox.php (modified) (history) /trunk/extensions/Crosswiki/Block/CrosswikiBlock.page.php (modified) (history) /trunk/extensions/DPLforum/DPLforum.php (modified) (history) /trunk/extensions/DataCenter/DataCenter.page.php (modified) (history) /trunk/extensions/DataTransfer/specials/DT_ImportCSV.php (modified) (history) /trunk/extensions/DataTransfer/specials/DT_ImportXML.php (modified) (history) /trunk/extensions/DataTransfer/specials/DT_ViewXML.php (modified) (history) /trunk/extensions/DeleteBatch/DeleteBatch.body.php (modified) (history) /trunk/extensions/DeleteQueue/DeleteQueue.hooks.php (modified) (history) /trunk/extensions/DeleteQueue/SpecialDeleteQueue.php (modified) (history) /trunk/extensions/DeleteQueue/Views/DeleteQueueViewList.php (modified) (history) /trunk/extensions/DiscussionThreading/DiscussionThreading.php (modified) (history) /trunk/extensions/Drafts/Drafts.classes.php (modified) (history) /trunk/extensions/Drafts/Drafts.hooks.php (modified) (history) /trunk/extensions/Drafts/Drafts.pages.php (modified) (history) /trunk/extensions/Duplicator/Duplicator.page.php (modified) (history) /trunk/extensions/Duplicator/Duplicator.php (modified) (history) /trunk/extensions/EditConflict/CurrentEdits.php (modified) (history) /trunk/extensions/EditConflict/EditConflict.php (modified) (history) /trunk/extensions/EditMessages/EditMessages_body.php (modified) (history) /trunk/extensions/EditSimilar/EditSimilar.php (modified) (history) /trunk/extensions/EditUser/EditUser_body.php (modified) (history) /trunk/extensions/Editcount/Editcount_body.php (modified) (history) /trunk/extensions/EmailPage/EmailPage_body.php (modified) (history) /trunk/extensions/EmbedVideo/EmbedVideo.hooks.php (modified) (history) /trunk/extensions/EmergencyDeSysop/EmergencyDeSysop.php (modified) (history) /trunk/extensions/EmergencyDeSysop/SpecialEmergencyDeSysop.php (modified) (history) /trunk/extensions/ErrorHandler/ErrorHandler.php (modified) (history) /trunk/extensions/Eval/Eval.class.php (modified) (history) /trunk/extensions/ExternalData/ED_GetData.php (modified) (history) /trunk/extensions/ExternalPages/ExternalPages_body.php (modified) (history) /trunk/extensions/FCKeditor/FCKeditor.body.php (modified) (history) /trunk/extensions/Farmer/SpecialFarmer.php (modified) (history) /trunk/extensions/FindSpam/FindSpam_body.php (modified) (history) /trunk/extensions/FlagPage/FlagPage.body.php (modified) (history) /trunk/extensions/FlagPage/FlagPage.hooks.php (modified) (history) /trunk/extensions/FlvHandler/FlvImageHandler.php (modified) (history) /trunk/extensions/ForcePreview/ForcePreview.php (modified) (history) /trunk/extensions/Form/Form.body.php (modified) (history) /trunk/extensions/FormatEmail/FormatEmail.php (modified) (history) /trunk/extensions/FramedVideo/FramedVideo.php (modified) (history) /trunk/extensions/FrontBackMatterForcedWikilinks/FrontBackMatterForcedWikilinks.php (modified) (history) /trunk/extensions/FundraiserPortal/DonateButton.php (modified) (history) /trunk/extensions/GlobalUserrights/GlobalUserrights_body.php (modified) (history) /trunk/extensions/GoogleAdSense/GoogleAdSense.class.php (modified) (history) /trunk/extensions/HoneypotIntegration/HoneypotIntegration.class.php (modified) (history)

Follow-up revisions

Revision	Commit summary	Author	Date
r76110	Reverted r76064 - it's too soon to remove wfLoadExtensionMessages(), which is...	yaron	16:22, 5 November 2010
r76112	Revert r76065 "Kill numerous wfLoadExtensionMessages calls more"...	simetrical	16:30, 5 November 2010

Comments

#Comment by Yaron Koren (talk | contribs) 13:58, 5 November 2010

Hi,

I think this mass removal was a bad idea, and I would like to see it reverted. As far as I can tell, it removes backward compatibility for versions of MediaWiki less than 1.16 - it just seems way too premature to do that, for a very negligible performance increase.

-Yaron

#Comment by Simetrical (talk | contribs) 16:12, 5 November 2010

Agree, needs revert. I'll start a wikitech-l discussion, since this basic dispute has come up before.

Status & tagging log

16:23, 5 November 2010 Simetrical (talk | contribs) changed the status of r76064 [removed: fixme added: reverted]
16:12, 5 November 2010 Simetrical (talk | contribs) changed the status of r76064 [removed: new added: fixme]