r76009 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r76008‎ | r76009 | r76010 >
Date:14:43, 4 November 2010
Author:reedy
Status:deferred
Tags:
Comment:
Remove unreachable code. Use correct string concatanator
Modified paths:
  • /trunk/extensions/MwEmbed/MwEmbed/includes/NamedResourceLoader.php (modified) (history)

Diff [purge]

Index: trunk/extensions/MwEmbed/MwEmbed/includes/NamedResourceLoader.php
@@ -265,8 +265,7 @@
266266 $jClassSet = FormatJson::decode( '{' . $jsvar[1] . '}', true );
267267 // Check for null json decode:
268268 if( $jClassSet == NULL ){
269 - throw new MWException( "Error could not decode javascript resource list for module: " + self::$currentModuleName + "\n" );
270 - return false;
 269+ throw new MWException( "Error could not decode javascript resource list for module: " . self::$currentModuleName . "\n" );
271270 }
272271
273272 foreach ( $jClassSet as $resourceName => $classPath ) {

Status & tagging log