r76010 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r76009‎ | r76010 | r76011 >
Date:14:48, 4 November 2010
Author:reedy
Status:ok
Tags:
Comment:
SemanticResultFormat: `$res;` as a code line, seriously?
Modified paths:
  • /trunk/extensions/SemanticResultFormats/GraphViz/SRF_Process.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticResultFormats/GraphViz/SRF_Process.php
@@ -175,11 +175,6 @@
176176 $row = $res->getNext(); // get initial row (i.e. array of SMWResultArray)
177177
178178 while ( $row !== false ) {
179 -
180 - $node;
181 - $cond_edge;
182 -
183 -
184179 $subject = $row[0]->getResultSubject(); // get Subject of the Result
185180 // creates a new node if $val has type wikipage
186181 if ( $subject->getTypeID() == '_wpg' ) {
@@ -411,8 +406,6 @@
412407 * @return Object of type ProcessNode
413408 */
414409 public function makeNode( $id, $label ) {
415 - $node;
416 -
417410 // check if node exists
418411 if ( isset( $this->m_nodes[$id] ) ) {
419412 // take existing node
@@ -447,8 +440,6 @@
448441 }
449442
450443 public function makeRole( $id, $label ) {
451 - $role;
452 -
453444 // check if role exists
454445 if ( isset( $this->m_roles[$id] ) ) {
455446 // take existing roles
@@ -468,8 +459,6 @@
469460 }
470461
471462 public function makeRessource( $id, $label ) {
472 - $res;
473 -
474463 // check if res exists
475464 if ( isset( $this->m_ressources[$id] ) ) {
476465 // take existing res

Status & tagging log