r75996 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r75995‎ | r75996 | r75997 >
Date:11:06, 4 November 2010
Author:raymond
Status:ok
Tags:
Comment:
* Special:Search: Add CSS classes to 'none found' and 'create link' messages
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/specials/SpecialSearch.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialSearch.php
@@ -302,7 +302,8 @@
303303 $textMatches->free();
304304 }
305305 if( $num === 0 ) {
306 - $wgOut->addWikiMsg( 'search-nonefound', wfEscapeWikiText( $term ) );
 306+ #$wgOut->addWikiMsg( 'search-nonefound', wfEscapeWikiText( $term ) );
 307+ $wgOut->wrapWikiMsg( "<p class=\"mw-search-nonefound\">\n$1</p>", array( 'search-nonefound', wfEscapeWikiText( $term ) ) );
307308 $this->showCreateLink( $t );
308309 }
309310 $wgOut->addHtml( "</div>" );
@@ -328,7 +329,7 @@
329330 }
330331 }
331332 if( $messageName ) {
332 - $wgOut->addWikiMsg( $messageName, wfEscapeWikiText( $t->getPrefixedText() ) );
 333+ $wgOut->wrapWikiMsg( "<p class=\"mw-search-createlink\">\n$1</p>", array( $messageName, wfEscapeWikiText( $t->getPrefixedText() ) ) );
333334 } else {
334335 // preserve the paragraph for margins etc...
335336 $wgOut->addHtml( '<p></p>' );
Index: trunk/phase3/RELEASE-NOTES
@@ -198,6 +198,7 @@
199199 * (bug 17394) Make installer check for latest version against MediaWiki.org
200200 * (bug 20627) Installer should be in languages other than English
201201 * Support for metadata in SVG files (title, description).
 202+* Special:Search: Add CSS classes to 'none found' and 'create link' messages
202203
203204 === Bug fixes in 1.17 ===
204205 * (bug 17560) Half-broken deletion moved image files to deletion archive

Follow-up revisions

RevisionCommit summaryAuthorDate
r75997Follow-up r75996: Forgotten to remove an old lineraymond11:08, 4 November 2010

Status & tagging log