r75919 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r75918‎ | r75919 | r75920 >
Date:12:41, 3 November 2010
Author:demon
Status:ok
Tags:
Comment:
Fix r69721: SQLite yells at you if you try to drop an index that doesn't exist; which might be the case considering how many times these indexes were renamed and dropped. Per r73758, put IF EXISTS on them--it certainly can't hurt.
Modified paths:
  • /trunk/phase3/maintenance/sqlite/archives/patch-kill-iwl_pft.sql (modified) (history)
  • /trunk/phase3/maintenance/sqlite/archives/patch-kill-iwl_prefix.sql (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/sqlite/archives/patch-kill-iwl_pft.sql
——@@ -3,5 +3,5 @@
44 -- installs if they ran update.php between it being added and being renamed
55 --
66
7 -DROP INDEX /*i*/iwl_prefix_from_title;
 7+DROP INDEX IF EXISTS /*i*/iwl_prefix;
88
Index: trunk/phase3/maintenance/sqlite/archives/patch-kill-iwl_prefix.sql
——@@ -3,5 +3,5 @@
44 -- installs if they ran update.php between it being added and being renamed
55 --
66
7 -DROP INDEX /*i*/iwl_prefix;
 7+DROP INDEX IF EXISTS /*i*/iwl_prefix;
88

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r69721Rename the iwl_prefix_from_title index (again) to iwl_prefix_title_from and c...catrope08:52, 22 July 2010
r73758A few index-related fixes in SQLite DB patches, ping r66920....maxsem17:45, 25 September 2010

Status & tagging log