r73758 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r73757‎ | r73758 | r73759 >
Date:17:45, 25 September 2010
Author:maxsem
Status:ok
Tags:
Comment:
A few index-related fixes in SQLite DB patches, ping r66920.

The need to drop index patch-rename-iwl_prefix.sql arose from development versions that had discrepancies between tables.sql and updater. Let's just DROP IF EXISTS it.
Modified paths:
  • /trunk/phase3/maintenance/sqlite/archives/patch-kill-iwl_pft.sql (modified) (history)
  • /trunk/phase3/maintenance/sqlite/archives/patch-kill-iwl_prefix.sql (modified) (history)
  • /trunk/phase3/maintenance/sqlite/archives/patch-rename-iwl_prefix.sql (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/sqlite/archives/patch-kill-iwl_pft.sql
@@ -3,5 +3,5 @@
44 -- installs if they ran update.php between it being added and being renamed
55 --
66
7 -DROP INDEX /*i*/iwl_prefix_from_title ON /*_*/iwlinks;
 7+DROP INDEX /*i*/iwl_prefix_from_title;
88
Index: trunk/phase3/maintenance/sqlite/archives/patch-rename-iwl_prefix.sql
@@ -1,5 +1,5 @@
22 --
33 -- Recreates the iwl_prefix for the iwlinks table
44 --
5 -DROP INDEX /*i*/iwl_prefix;
 5+DROP INDEX IF EXISTS /*i*/iwl_prefix;
66 CREATE INDEX /*i*/iwl_prefix_from_title ON /*_*/iwlinks (iwl_prefix, iwl_from, iwl_title);
\ No newline at end of file
Index: trunk/phase3/maintenance/sqlite/archives/patch-kill-iwl_prefix.sql
@@ -3,5 +3,5 @@
44 -- installs if they ran update.php between it being added and being renamed
55 --
66
7 -DROP INDEX /*i*/iwl_prefix ON /*_*/iwlinks;
 7+DROP INDEX /*i*/iwl_prefix;
88

Follow-up revisions

RevisionCommit summaryAuthorDate
r75919Fix r69721: SQLite yells at you if you try to drop an index that doesn't exis...demon12:41, 3 November 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r66920follow-up to r66892: fix update SQL on on SQLitemaxsem14:29, 26 May 2010

Status & tagging log