r75907 MediaWiki - Code Review archive

Repository:	MediaWiki
Revision:	< r75906‎ \| r75907 \| r75908 >
Date:	04:33, 3 November 2010
Author:	neilk
Status:	deferred (Comments)
Tags:
Comment:	extension changes for UploadWizard (merged from r73549 to HEAD in branches/uploadwizard/phase3)
Modified paths:	/trunk/extensions/UploadWizard (modified) (history) /trunk/extensions/UploadWizard/ApiQueryStashImageInfo.php (added) (history) /trunk/extensions/UploadWizard/SpecialUploadWizard.php (modified) (history) /trunk/extensions/UploadWizard/UploadWizard.i18n.php (modified) (history) /trunk/extensions/UploadWizard/UploadWizard.php (modified) (history) /trunk/extensions/UploadWizard/UploadWizardHooks.php (added) (history) /trunk/extensions/UploadWizard/UploadWizardMessages.php (added) (history) /trunk/extensions/UploadWizard/UploadWizardPage.js (modified) (history) /trunk/extensions/UploadWizard/resources/apiTokenMisc.js (added) (history) /trunk/extensions/UploadWizard/resources/jquery.ui (added) (history) /trunk/extensions/UploadWizard/resources/jquery/jquery.autoSuggest.js (modified) (history) /trunk/extensions/UploadWizard/resources/jquery/jquery.autocomplete.css (added) (history) /trunk/extensions/UploadWizard/resources/jquery/jquery.autocomplete.js (added) (history) /trunk/extensions/UploadWizard/resources/jquery/jquery.datePicker.js (added) (history) /trunk/extensions/UploadWizard/resources/jquery/jquery.mwCoolCats.js (modified) (history) /trunk/extensions/UploadWizard/resources/jquery/jquery.spinner.js (added) (history) /trunk/extensions/UploadWizard/resources/jquery/jquery.tipsyPlus.js (added) (history) /trunk/extensions/UploadWizard/resources/language (added) (history) /trunk/extensions/UploadWizard/resources/mw.Api.edit.js (added) (history) /trunk/extensions/UploadWizard/resources/mw.Api.js (added) (history) /trunk/extensions/UploadWizard/resources/mw.ApiMisc.js (added) (history) /trunk/extensions/UploadWizard/resources/mw.ApiProxy.js (added) (history) /trunk/extensions/UploadWizard/resources/mw.ApiUploadHandler.js (modified) (history) /trunk/extensions/UploadWizard/resources/mw.DestinationChecker.js (modified) (history) /trunk/extensions/UploadWizard/resources/mw.GroupProgressBar.js (added) (history) /trunk/extensions/UploadWizard/resources/mw.IframeTransport.js (modified) (history) /trunk/extensions/UploadWizard/resources/mw.LanguageUpWiz.js (modified) (history) /trunk/extensions/UploadWizard/resources/mw.Log.js (modified) (history) /trunk/extensions/UploadWizard/resources/mw.Title.js (added) (history) /trunk/extensions/UploadWizard/resources/mw.UploadWizard.js (modified) (history) /trunk/extensions/UploadWizard/resources/mw.UploadWizardDeed.js (added) (history) /trunk/extensions/UploadWizard/resources/mw.UploadWizardLicenseInput.js (added) (history) /trunk/extensions/UploadWizard/resources/mw.UploadWizardUtil.js (added) (history) /trunk/extensions/UploadWizard/resources/mw.Uri.js (added) (history) /trunk/extensions/UploadWizard/resources/mw.Utilities.js (modified) (history) /trunk/extensions/UploadWizard/resources/mw.UtilitiesTime.js (modified) (history) /trunk/extensions/UploadWizard/resources/mw.js (added) (history) /trunk/extensions/UploadWizard/resources/uploadWizard.css (modified) (history) /trunk/extensions/UploadWizard/test (added) (history)

Diff [purge]

The diff is too large to display.

Follow-up revisions

Revision	Commit summary	Author	Date
r75915	Follow-up r75907: Consistence spelling of JavaScript	raymond	12:24, 3 November 2010

Past revisions this follows-up on

Revision	Commit summary	Author	Date
r73549	making a branch for uploadwizard	neilk	18:02, 22 September 2010

Comments

#Comment by Raymond (talk | contribs) 20:49, 3 November 2010

Testing in my local wiki running trunk:

Notice:  Undefined variable: wgResourceLoader in \UploadWizard\SpecialUploadWizard.php on line 60

Notice:  Undefined variable: wgLanguageCode in \UploadWizard\SpecialUploadWizard.php on line 77

Notice:  Undefined variable: wgLanguageCode in \UploadWizard\SpecialUploadWizard.php on line 77

#Comment by Catrope (talk | contribs) 12:58, 4 November 2010

There is no such variable as $wgResourceLoader, so use something like class_exists( 'ResourceLoader' ). $wgLanguageCode is simply not being globaled.

#Comment by NeilK (talk | contribs) 01:21, 16 November 2010

fixed both issues in r76424

Status & tagging log

01:07, 5 January 2011 Reedy (talk | contribs) changed the status of r75907 [removed: new added: deferred]
01:30, 16 November 2010 NeilK (talk | contribs) changed the status of r75907 [removed: fixme added: new]
14:34, 4 November 2010 Catrope (talk | contribs) changed the tags for r75907 [removed: uwdeploy]
12:59, 4 November 2010 Catrope (talk | contribs) changed the tags for r75907 [added: uwdeploy]
20:49, 3 November 2010 Raymond (talk | contribs) changed the status of r75907 [removed: new added: fixme]