r75856 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r75855‎ | r75856 | r75857 >
Date:15:52, 2 November 2010
Author:maxsem
Status:ok (Comments)
Tags:
Comment:
Fix bug caused by variable reuse from r71902
Modified paths:
  • /trunk/phase3/includes/CategoryPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/CategoryPage.php
@@ -587,8 +587,8 @@
588588
589589 # Check if there's a "from" or "until" for anything
590590 $fromOrUntil = false;
591 - foreach ( array( 'page', 'subcat', 'file' ) as $type ) {
592 - if ( $this->from[$type] !== null || $this->until[$type] !== null ) {
 591+ foreach ( array( 'page', 'subcat', 'file' ) as $t ) {
 592+ if ( $this->from[$t] !== null || $this->until[$t] !== null ) {
593593 $fromOrUntil = true;
594594 break;
595595 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r71902Fix category count when category table out of sync...simetrical21:21, 29 August 2010

Comments

#Comment by Simetrical (talk | contribs)   16:24, 2 November 2010

Thanks. You should specify in the commit message what the observable effect of the bug is, so it's easier to check that the fix it valid -- it looks like it would have always printed the category-file-count(-limited) instead of varying the message by the type.

Status & tagging log