r75802 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r75801‎ | r75802 | r75803 >
Date:16:54, 1 November 2010
Author:demon
Status:reverted (Comments)
Tags:
Comment:
Need a way to show unlinked accounts
Modified paths:
  • /trunk/extensions/CodeReview/ui/CodeAuthorListView.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/ui/CodeAuthorListView.php
@@ -8,9 +8,10 @@
99 }
1010
1111 function execute() {
12 - global $wgOut, $wgLang;
 12+ global $wgOut, $wgLang, $wgRequest;
1313 $authors = $this->mRepo->getAuthorList();
1414 $repo = $this->mRepo->getName();
 15+ $hideLinked = $wgRequest->getBool( 'unlinkedonly' );
1516 $text = wfMsg( 'code-authors-text' ) . "\n\n";
1617 $text .= '<strong>' . wfMsg( 'code-author-total', $wgLang->formatNum( $this->mRepo->getAuthorCount() ) ) . "</strong>\n";
1718
@@ -22,15 +23,18 @@
2324
2425 foreach ( $authors as $committer ) {
2526 if ( $committer ) {
26 - $wgOut->addHTML( "<tr><td>" );
2727 $author = $committer["author"];
2828 $text = "[[Special:Code/$repo/author/$author|$author]]";
2929 $user = $this->mRepo->authorWikiUser( $author );
3030 if ( $user ) {
 31+ if( $hideLinked ) {
 32+ continue;
 33+ }
3134 $title = htmlspecialchars( $user->getUserPage()->getPrefixedText() );
3235 $name = htmlspecialchars( $user->getName() );
3336 $text .= " ([[$title|$name]])";
3437 }
 38+ $wgOut->addHTML( "<tr><td>" );
3539 $wgOut->addWikiText( $text );
3640 $wgOut->addHTML( "</td><td>{$wgLang->timeanddate( $committer['lastcommit'], true )}</td></tr>" );
3741 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r76724Revert r75802 (adding hidden feature to only show unlinked accounts)demon22:21, 15 November 2010

Comments

#Comment by Hashar (talk | contribs)   21:00, 5 November 2010

Should be a filtering link at the top. I tend to dislike hidden features. An additional filter could be active / inactive authors. Where inactive is a given threshold (say 1 year).

Status & tagging log