r75794 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r75793‎ | r75794 | r75795 >
Date:15:12, 1 November 2010
Author:demon
Status:ok
Tags:
Comment:
Revert r69360 (adding ob_flush() to WebInstallerOutput::flush()). Per CR, this doesn't seem necessary and actually causes a regression for some environments. In other news: I hate PHP output buffering and I don't feel like digging back into this right now.
Modified paths:
  • /trunk/phase3/includes/installer/WebInstallerOutput.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/installer/WebInstallerOutput.php
——@@ -87,7 +87,6 @@
8888 }
8989 if ( !$this->redirectTarget && strlen( $this->contents ) ) {
9090 echo $this->contents;
91 - ob_flush();
9291 flush();
9392 $this->contents = '';
9493 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r69360Fix flush(). Need ob_flush()demon23:07, 14 July 2010

Status & tagging log