r75722 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r75721‎ | r75722 | r75723 >
Date:16:20, 31 October 2010
Author:reedy
Status:resolved (Comments)
Tags:
Comment:
Update deprecated method calls

Remove some unused stuff
Modified paths:
  • /trunk/phase3/includes/Article.php (modified) (history)
  • /trunk/phase3/includes/ChangeTags.php (modified) (history)
  • /trunk/phase3/includes/FileDeleteForm.php (modified) (history)
  • /trunk/phase3/includes/FileRevertForm.php (modified) (history)
  • /trunk/phase3/includes/HistoryPage.php (modified) (history)
  • /trunk/phase3/includes/LogEventsList.php (modified) (history)
  • /trunk/phase3/includes/db/DatabaseMssql.php (modified) (history)
  • /trunk/phase3/includes/installer/WebInstallerPage.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialActiveusers.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialAllmessages.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialAllpages.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialBooksources.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialCategories.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialComparePages.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialConfirmemail.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialFileDuplicateSearch.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialImport.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialLinkSearch.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialListusers.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialMIMEsearch.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialMergeHistory.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialNewpages.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialPrefixindex.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialProtectedpages.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialProtectedtitles.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialResetpass.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialRevisionMove.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialWithoutinterwiki.php (modified) (history)
  • /trunk/phase3/languages/Language.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/FileRevertForm.php
——@@ -92,7 +92,7 @@
9393 $timestamp = $this->getTimestamp();
9494
9595 $form = Xml::openElement( 'form', array( 'method' => 'post', 'action' => $this->getAction() ) );
96 - $form .= Xml::hidden( 'wpEditToken', $wgUser->editToken( $this->archiveName ) );
 96+ $form .= Html::hidden( 'wpEditToken', $wgUser->editToken( $this->archiveName ) );
9797 $form .= '<fieldset><legend>' . wfMsgHtml( 'filerevert-legend' ) . '</legend>';
9898 $form .= wfMsgExt( 'filerevert-intro', 'parse', $this->title->getText(),
9999 $wgLang->date( $timestamp, true ), $wgLang->time( $timestamp, true ),
Index: trunk/phase3/includes/Article.php
——@@ -2125,8 +2125,6 @@
21262126 $userAbort = ignore_user_abort( true );
21272127 }
21282128
2129 - $revisionId = 0;
2130 -
21312129 $changed = ( strcmp( $text, $oldtext ) != 0 );
21322130
21332131 if ( $changed ) {
Index: trunk/phase3/includes/db/DatabaseMssql.php
——@@ -1181,7 +1181,6 @@
11821182 public function fieldtype( $nr ) {
11831183 $i = 0;
11841184 $intType = -1;
1185 - $strType = '';
11861185 foreach ( $this->mFieldMeta as $meta ) {
11871186 if ( $nr == $i ) {
11881187 $intType = $meta['Type'];
Index: trunk/phase3/includes/ChangeTags.php
——@@ -169,7 +169,7 @@
170170
171171 $html = implode( '&#160;', $data );
172172 $html .= "\n" . Xml::element( 'input', array( 'type' => 'submit', 'value' => wfMsg( 'tag-filter-submit' ) ) );
173 - $html .= "\n" . Xml::hidden( 'title', $wgTitle-> getPrefixedText() );
 173+ $html .= "\n" . Html::hidden( 'title', $wgTitle-> getPrefixedText() );
174174 $html = Xml::tags( 'form', array( 'action' => $wgTitle->getLocalURL(), 'method' => 'get' ), $html );
175175
176176 return $html;
Index: trunk/phase3/includes/HistoryPage.php
——@@ -146,8 +146,8 @@
147147 false,
148148 array( 'id' => 'mw-history-search' )
149149 ) .
150 - Xml::hidden( 'title', $this->title->getPrefixedDBKey() ) . "\n" .
151 - Xml::hidden( 'action', 'history' ) . "\n" .
 150+ Html::hidden( 'title', $this->title->getPrefixedDBKey() ) . "\n" .
 151+ Html::hidden( 'action', 'history' ) . "\n" .
152152 Xml::dateMenu( $year, $month ) . '&#160;' .
153153 ( $tagSelector ? ( implode( '&#160;', $tagSelector ) . '&#160;' ) : '' ) .
154154 $checkDeleted .
Index: trunk/phase3/includes/LogEventsList.php
——@@ -95,8 +95,7 @@
9696
9797 $tagSelector = ChangeTags::buildTagFilterSelector( $tagFilter );
9898
99 - $html = '';
100 - $html .= Xml::hidden( 'title', $special );
 99+ $html = Html::hidden( 'title', $special );
101100
102101 // Basic selectors
103102 $html .= $this->getTypeMenu( $types ) . "\n";
——@@ -163,7 +162,7 @@
164163 );
165164
166165 $links[$type] = wfMsgHtml( "log-show-hide-{$type}", $link );
167 - $hiddens .= Xml::hidden( "hide_{$type}_log", $val ) . "\n";
 166+ $hiddens .= Html::hidden( "hide_{$type}_log", $val ) . "\n";
168167 }
169168 // Build links
170169 return '<small>'.$wgLang->pipeList( $links ) . '</small>' . $hiddens;
Index: trunk/phase3/includes/installer/WebInstallerPage.php
——@@ -55,7 +55,7 @@
5656 $id = $this->getId();
5757
5858 if ( $id === false ) {
59 - $s .= Xml::hidden( 'lastPage', $this->parent->request->getVal( 'lastPage' ) );
 59+ $s .= Html::hidden( 'lastPage', $this->parent->request->getVal( 'lastPage' ) );
6060 }
6161
6262 if ( $continue ) {
Index: trunk/phase3/includes/FileDeleteForm.php
——@@ -174,7 +174,7 @@
175175 'id' => 'mw-img-deleteconfirm' ) ) .
176176 Xml::openElement( 'fieldset' ) .
177177 Xml::element( 'legend', null, wfMsg( 'filedelete-legend' ) ) .
178 - Xml::hidden( 'wpEditToken', $wgUser->editToken( $this->oldimage ) ) .
 178+ Html::hidden( 'wpEditToken', $wgUser->editToken( $this->oldimage ) ) .
179179 $this->prepareMessage( 'filedelete-intro' ) .
180180 Xml::openElement( 'table', array( 'id' => 'mw-img-deleteconfirm-table' ) ) .
181181 "<tr>
Index: trunk/phase3/includes/specials/SpecialAllpages.php
——@@ -98,7 +98,7 @@
9999
100100 $out = Xml::openElement( 'div', array( 'class' => 'namespaceoptions' ) );
101101 $out .= Xml::openElement( 'form', array( 'method' => 'get', 'action' => $wgScript ) );
102 - $out .= Xml::hidden( 'title', $t->getPrefixedText() );
 102+ $out .= Html::hidden( 'title', $t->getPrefixedText() );
103103 $out .= Xml::openElement( 'fieldset' );
104104 $out .= Xml::element( 'legend', null, wfMsg( 'allpages' ) );
105105 $out .= Xml::openElement( 'table', array( 'id' => 'nsselect', 'class' => 'allpages' ) );
Index: trunk/phase3/includes/specials/SpecialAllmessages.php
——@@ -81,7 +81,7 @@
8282
8383 $out = Xml::openElement( 'form', array( 'method' => 'get', 'action' => $wgScript, 'id' => 'mw-allmessages-form' ) ) .
8484 Xml::fieldset( wfMsg( 'allmessages-filter-legend' ) ) .
85 - Xml::hidden( 'title', $this->getTitle()->getPrefixedText() ) .
 85+ Html::hidden( 'title', $this->getTitle()->getPrefixedText() ) .
8686 Xml::openElement( 'table', array( 'class' => 'mw-allmessages-table' ) ) . "\n" .
8787 '<tr>
8888 <td class="mw-label">' .
Index: trunk/phase3/includes/specials/SpecialNewpages.php
——@@ -196,7 +196,7 @@
197197 // Store query values in hidden fields so that form submission doesn't lose them
198198 $hidden = array();
199199 foreach ( $this->opts->getUnconsumedValues() as $key => $value ) {
200 - $hidden[] = Xml::hidden( $key, $value );
 200+ $hidden[] = Html::hidden( $key, $value );
201201 }
202202 $hidden = implode( "\n", $hidden );
203203
Index: trunk/phase3/includes/specials/SpecialImport.php
——@@ -150,8 +150,8 @@
151151 Xml::fieldset( wfMsg( 'import-upload' ) ).
152152 Xml::openElement( 'form', array( 'enctype' => 'multipart/form-data', 'method' => 'post',
153153 'action' => $action, 'id' => 'mw-import-upload-form' ) ) .
154 - Xml::hidden( 'action', 'submit' ) .
155 - Xml::hidden( 'source', 'upload' ) .
 154+ Html::hidden( 'action', 'submit' ) .
 155+ Html::hidden( 'source', 'upload' ) .
156156 Xml::openElement( 'table', array( 'id' => 'mw-import-table' ) ) .
157157
158158 "<tr>
——@@ -178,7 +178,7 @@
179179 "</td>
180180 </tr>" .
181181 Xml::closeElement( 'table' ).
182 - Xml::hidden( 'editToken', $wgUser->editToken() ) .
 182+ Html::hidden( 'editToken', $wgUser->editToken() ) .
183183 Xml::closeElement( 'form' ) .
184184 Xml::closeElement( 'fieldset' )
185185 );
Index: trunk/phase3/includes/specials/SpecialCategories.php
——@@ -127,7 +127,7 @@
128128
129129 return
130130 Xml::tags( 'form', array( 'method' => 'get', 'action' => $wgScript ),
131 - Xml::hidden( 'title', $t->getPrefixedText() ) .
 131+ Html::hidden( 'title', $t->getPrefixedText() ) .
132132 Xml::fieldset( wfMsg( 'categories' ),
133133 Xml::inputLabel( wfMsg( 'categoriesfrom' ),
134134 'from', 'from', 20, $from ) .
Index: trunk/phase3/includes/specials/SpecialFileDuplicateSearch.php
——@@ -101,7 +101,7 @@
102102 # Create the input form
103103 $wgOut->addHTML(
104104 Xml::openElement( 'form', array( 'id' => 'fileduplicatesearch', 'method' => 'get', 'action' => $wgScript ) ) .
105 - Xml::hidden( 'title', SpecialPage::getTitleFor( 'FileDuplicateSearch' )->getPrefixedDbKey() ) .
 105+ Html::hidden( 'title', SpecialPage::getTitleFor( 'FileDuplicateSearch' )->getPrefixedDbKey() ) .
106106 Xml::openElement( 'fieldset' ) .
107107 Xml::element( 'legend', null, wfMsg( 'fileduplicatesearch-legend' ) ) .
108108 Xml::inputLabel( wfMsg( 'fileduplicatesearch-filename' ), 'filename', 'filename', 50, $filename ) . ' ' .
Index: trunk/phase3/includes/specials/SpecialComparePages.php
——@@ -120,7 +120,7 @@
121121 // Store query values in hidden fields so that form submission doesn't lose them
122122 $hidden = array();
123123 foreach ( $this->opts->getUnconsumedValues() as $key => $value ) {
124 - $hidden[] = Xml::hidden( $key, $value );
 124+ $hidden[] = Html::hidden( $key, $value );
125125 }
126126 $hidden = implode( "\n", $hidden );
127127
Index: trunk/phase3/includes/specials/SpecialProtectedtitles.php
——@@ -119,7 +119,7 @@
120120 return "<form action=\"$action\" method=\"get\">\n" .
121121 '<fieldset>' .
122122 Xml::element( 'legend', array(), wfMsg( 'protectedtitles' ) ) .
123 - Xml::hidden( 'title', $special ) . "&#160;\n" .
 123+ Html::hidden( 'title', $special ) . "&#160;\n" .
124124 $this->getNamespaceMenu( $namespace ) . "&#160;\n" .
125125 $this->getLevelMenu( $level ) . "&#160;\n" .
126126 "&#160;" . Xml::submitButton( wfMsg( 'allpagessubmit' ) ) . "\n" .
Index: trunk/phase3/includes/specials/SpecialPrefixindex.php
——@@ -76,7 +76,7 @@
7777
7878 $out = Xml::openElement( 'div', array( 'class' => 'namespaceoptions' ) );
7979 $out .= Xml::openElement( 'form', array( 'method' => 'get', 'action' => $wgScript ) );
80 - $out .= Xml::hidden( 'title', $t->getPrefixedText() );
 80+ $out .= Html::hidden( 'title', $t->getPrefixedText() );
8181 $out .= Xml::openElement( 'fieldset' );
8282 $out .= Xml::element( 'legend', null, wfMsg( 'allpages' ) );
8383 $out .= Xml::openElement( 'table', array( 'id' => 'nsselect', 'class' => 'allpages' ) );
Index: trunk/phase3/includes/specials/SpecialWithoutinterwiki.php
——@@ -48,7 +48,7 @@
4949 return Xml::openElement( 'form', array( 'method' => 'get', 'action' => $wgScript ) ) .
5050 Xml::openElement( 'fieldset' ) .
5151 Xml::element( 'legend', null, wfMsg( 'withoutinterwiki-legend' ) ) .
52 - Xml::hidden( 'title', $t->getPrefixedText() ) .
 52+ Html::hidden( 'title', $t->getPrefixedText() ) .
5353 Xml::inputLabel( wfMsg( 'allpagesprefix' ), 'prefix', 'wiprefix', 20, $prefix ) . ' ' .
5454 Xml::submitButton( wfMsg( 'withoutinterwiki-submit' ) ) .
5555 Xml::closeElement( 'fieldset' ) .
Index: trunk/phase3/includes/specials/SpecialListusers.php
——@@ -182,7 +182,7 @@
183183 # Form tag
184184 $out = Xml::openElement( 'form', array( 'method' => 'get', 'action' => $wgScript, 'id' => 'mw-listusers-form' ) ) .
185185 Xml::fieldset( wfMsg( 'listusers' ) ) .
186 - Xml::hidden( 'title', $self->getPrefixedDbKey() );
 186+ Html::hidden( 'title', $self->getPrefixedDbKey() );
187187
188188 # Username field
189189 $out .= Xml::label( wfMsg( 'listusersfrom' ), 'offset' ) . ' ' .
——@@ -203,7 +203,7 @@
204204 wfRunHooks( 'SpecialListusersHeaderForm', array( $this, &$out ) );
205205
206206 # Submit button and form bottom
207 - $out .= Xml::hidden( 'limit', $this->mLimit );
 207+ $out .= Html::hidden( 'limit', $this->mLimit );
208208 $out .= Xml::submitButton( wfMsg( 'allpagessubmit' ) );
209209 wfRunHooks( 'SpecialListusersHeader', array( $this, &$out ) );
210210 $out .= Xml::closeElement( 'fieldset' ) .
Index: trunk/phase3/includes/specials/SpecialActiveusers.php
——@@ -136,11 +136,11 @@
137137 global $wgScript;
138138
139139 $self = $this->getTitle();
140 - $limit = $this->mLimit ? Xml::hidden( 'limit', $this->mLimit ) : '';
 140+ $limit = $this->mLimit ? Html::hidden( 'limit', $this->mLimit ) : '';
141141
142 - $out = Xml::openElement( 'form', array( 'method' => 'get', 'action' => $wgScript ) ); # Form tag
 142+ $out = Xml::openElement( 'form', array( 'method' => 'get', 'action' => $wgScript ) ); # Form tag
143143 $out .= Xml::fieldset( wfMsg( 'activeusers' ) ) . "\n";
144 - $out .= Xml::hidden( 'title', $self->getPrefixedDBkey() ) . $limit . "\n";
 144+ $out .= Html::hidden( 'title', $self->getPrefixedDBkey() ) . $limit . "\n";
145145
146146 $out .= Xml::inputLabel( wfMsg( 'activeusers-from' ), 'username', 'offset', 20, $this->requestedUser ) . '<br />';# Username field
147147
Index: trunk/phase3/includes/specials/SpecialBooksources.php
——@@ -119,7 +119,7 @@
120120 $title = self::getTitleFor( 'Booksources' );
121121 $form = '<fieldset><legend>' . wfMsgHtml( 'booksources-search-legend' ) . '</legend>';
122122 $form .= Xml::openElement( 'form', array( 'method' => 'get', 'action' => $wgScript ) );
123 - $form .= Xml::hidden( 'title', $title->getPrefixedText() );
 123+ $form .= Html::hidden( 'title', $title->getPrefixedText() );
124124 $form .= '<p>' . Xml::inputLabel( wfMsg( 'booksources-isbn' ), 'isbn', 'isbn', 20, $this->isbn );
125125 $form .= '&#160;' . Xml::submitButton( wfMsg( 'booksources-go' ) ) . '</p>';
126126 $form .= Xml::closeElement( 'form' );
Index: trunk/phase3/includes/specials/SpecialConfirmemail.php
——@@ -102,7 +102,7 @@
103103 }
104104 $wgOut->addWikiMsg( 'confirmemail_text' );
105105 $form = Xml::openElement( 'form', array( 'method' => 'post', 'action' => $this->getTitle()->getLocalUrl() ) );
106 - $form .= Xml::hidden( 'token', $wgUser->editToken() );
 106+ $form .= Html::hidden( 'token', $wgUser->editToken() );
107107 $form .= Xml::submitButton( wfMsg( 'confirmemail_send' ) );
108108 $form .= Xml::closeElement( 'form' );
109109 $wgOut->addHTML( $form );
Index: trunk/phase3/includes/specials/SpecialResetpass.php
——@@ -140,9 +140,9 @@
141141 'method' => 'post',
142142 'action' => $self->getLocalUrl(),
143143 'id' => 'mw-resetpass-form' ) ) . "\n" .
144 - Xml::hidden( 'token', $wgUser->editToken() ) . "\n" .
145 - Xml::hidden( 'wpName', $this->mUserName ) . "\n" .
146 - Xml::hidden( 'returnto', $wgRequest->getVal( 'returnto' ) ) . "\n" .
 144+ Html::hidden( 'token', $wgUser->editToken() ) . "\n" .
 145+ Html::hidden( 'wpName', $this->mUserName ) . "\n" .
 146+ Html::hidden( 'returnto', $wgRequest->getVal( 'returnto' ) ) . "\n" .
147147 wfMsgExt( 'resetpass_text', array( 'parse' ) ) . "\n" .
148148 Xml::openElement( 'table', array( 'id' => 'mw-resetpass-table' ) ) . "\n" .
149149 $this->pretty( array(
Index: trunk/phase3/includes/specials/SpecialProtectedpages.php
——@@ -158,7 +158,7 @@
159159 return Xml::openElement( 'form', array( 'method' => 'get', 'action' => $wgScript ) ) .
160160 Xml::openElement( 'fieldset' ) .
161161 Xml::element( 'legend', array(), wfMsg( 'protectedpages' ) ) .
162 - Xml::hidden( 'title', $title->getPrefixedDBkey() ) . "\n" .
 162+ Html::hidden( 'title', $title->getPrefixedDBkey() ) . "\n" .
163163 $this->getNamespaceMenu( $namespace ) . "&#160;\n" .
164164 $this->getTypeMenu( $type ) . "&#160;\n" .
165165 $this->getLevelMenu( $level ) . "&#160;\n" .
Index: trunk/phase3/includes/specials/SpecialMIMEsearch.php
——@@ -107,7 +107,7 @@
108108 $wgOut->addHTML(
109109 Xml::openElement( 'form', array( 'id' => 'specialmimesearch', 'method' => 'get', 'action' => SpecialPage::getTitleFor( 'MIMEsearch' )->getLocalUrl() ) ) .
110110 Xml::openElement( 'fieldset' ) .
111 - Xml::hidden( 'title', SpecialPage::getTitleFor( 'MIMEsearch' )->getPrefixedText() ) .
 111+ Html::hidden( 'title', SpecialPage::getTitleFor( 'MIMEsearch' )->getPrefixedText() ) .
112112 Xml::element( 'legend', null, wfMsg( 'mimesearch' ) ) .
113113 Xml::inputLabel( wfMsg( 'mimetype' ), 'mime', 'mime', 20, $mime ) . ' ' .
114114 Xml::submitButton( wfMsg( 'ilsubmit' ) ) .
Index: trunk/phase3/includes/specials/SpecialMergeHistory.php
——@@ -142,9 +142,9 @@
143143 '<fieldset>' .
144144 Xml::element( 'legend', array(),
145145 wfMsg( 'mergehistory-box' ) ) .
146 - Xml::hidden( 'title', $this->getTitle()->getPrefixedDbKey() ) .
147 - Xml::hidden( 'submitted', '1' ) .
148 - Xml::hidden( 'mergepoint', $this->mTimestamp ) .
 146+ Html::hidden( 'title', $this->getTitle()->getPrefixedDbKey() ) .
 147+ Html::hidden( 'submitted', '1' ) .
 148+ Html::hidden( 'mergepoint', $this->mTimestamp ) .
149149 Xml::openElement( 'table' ) .
150150 "<tr>
151151 <td>".Xml::label( wfMsg( 'mergehistory-from' ), 'target' )."</td>
Index: trunk/phase3/includes/specials/SpecialLinkSearch.php
——@@ -63,8 +63,8 @@
6464 $self = Title::makeTitle( NS_SPECIAL, 'Linksearch' );
6565
6666 $wgOut->addWikiMsg( 'linksearch-text', '<nowiki>' . $wgLang->commaList( $wgUrlProtocols ) . '</nowiki>' );
67 - $s = Xml::openElement( 'form', array( 'id' => 'mw-linksearch-form', 'method' => 'get', 'action' => $GLOBALS['wgScript'] ) ) .
68 - Xml::hidden( 'title', $self->getPrefixedDbKey() ) .
 67+ $s = Xml::openElement( 'form', array( 'id' => 'mw-linksearch-form', 'method' => 'get', 'action' => $GLOBALS['wgScript'] ) ) .
 68+ Html::hidden( 'title', $self->getPrefixedDbKey() ) .
6969 '<fieldset>' .
7070 Xml::element( 'legend', array(), wfMsg( 'linksearch' ) ) .
7171 Xml::inputLabel( wfMsg( 'linksearch-pat' ), 'target', 'target', 50, $target ) . ' ';
Index: trunk/phase3/includes/specials/SpecialRevisionMove.php
——@@ -149,11 +149,11 @@
150150 'action' => $this->getTitle()->getLocalUrl( array( 'action' => 'submit' ) ),
151151 'id' => 'mw-revmove-form' ) ) .
152152 Xml::fieldset( wfMsg( 'revmove-legend' ) ) .
153 - Xml::hidden( 'wpEditToken', $wgUser->editToken() ) .
154 - Xml::hidden( 'oldTitle', $this->mOldTitle->getPrefixedText() ) .
 153+ Html::hidden( 'wpEditToken', $wgUser->editToken() ) .
 154+ Html::hidden( 'oldTitle', $this->mOldTitle->getPrefixedText() ) .
155155 '<div>' . Xml::inputLabel( wfMsg( 'revmove-reasonfield' ), 'wpReason', 'revmove-reasonfield', 60 ) . '</div>' .
156156 Xml::inputLabel( wfMsg( 'revmove-titlefield' ), 'newTitle', 'revmove-titlefield', 20, $this->mOldTitle->getPrefixedText() ) .
157 - Xml::hidden( 'ids', implode( ',', $this->mIds ) ) .
 157+ Html::hidden( 'ids', implode( ',', $this->mIds ) ) .
158158 Xml::submitButton( wfMsg( 'revmove-submit' ),
159159 array( 'name' => 'wpSubmit' ) ) .
160160 Xml::closeElement( 'fieldset' ) . "\n" .
Index: trunk/phase3/languages/Language.php
——@@ -977,7 +977,6 @@
978978 } else {
979979 $s .= $this->formatNum( $num, true );
980980 }
981 - $num = false;
982981 }
983982 }
984983 return $s;

Follow-up revisions

RevisionCommit summaryAuthorDate
r84574Remove sneaky space in class-> method() call...hashar22:26, 22 March 2011

Comments

#Comment by Hashar (talk | contribs)   22:29, 22 March 2011

I have spotted a space in ChangeTags.php : 

$wgTitle-> getPrefixedText()

Fixed by r84574

#Comment by Catrope (talk | contribs)   16:32, 23 March 2011

WHY is this tagged 1.17wmf1? It's more than 2,000 revisions before the branch point.

#Comment by Hashar (talk | contribs)   18:51, 23 March 2011

Sorry. I wanted to highlight this revision as a potential trouble in 1.17. Just like marking it as blocking 1.17.

Instead, I should only have marked the fix which is r84574.

Status & tagging log