r75692 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r75691‎ | r75692 | r75693 >
Date:05:42, 30 October 2010
Author:philip
Status:deferred (Comments)
Tags:
Comment:
Forgot to commit this one. parserTests fix for
r75617 (in trunk/phase3/includes/Title.php).
Modified paths:
  • /trunk/phase3/maintenance/tests/parser/parserTests.txt (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/tests/parser/parserTests.txt
@@ -7396,7 +7396,7 @@
73977397 !! input
73987398 -{[[Main Page]]}-
73997399 !! result
7400 -<p><a href="https://www.mediawiki.org/index.php?title=Main_Page&amp;variant=sr-ec" title="Main Page">Main Page</a>
 7400+<p><a href="https://www.mediawiki.org/wiki/Main_Page" title="Main Page">Main Page</a>
74017401 </p>
74027402 !! end
74037403

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r756171. Revert the complicated redirection I made in r59754;...philip16:58, 28 October 2010

Comments

#Comment by Platonides (talk | contribs)   20:32, 30 October 2010

The pages worked like this since at least 2007, when this parser test was added. Can you explain the change and how this new behavior is preferable?

#Comment by PhiLiP (talk | contribs)   03:26, 31 October 2010

The variant stuff was introduced since there was a long standing squid-cache problem when provide page to anonymous users - if no variant has been specified, it would provide page's variant by random. This problem has been partly resolved at r60272 which provide all-lowercase-form language code in XVO. In r75617, I added letter-half-uppercase-form which are widely used by broswers like IE. Then I feel the squid-cache problem has been resolved completely, so there's no need to guide a anonymous user to a "variant page" any more. That's why I remove the variant stuff.

#Comment by Bawolff (talk | contribs)   03:36, 31 October 2010

Without knowing anything at all about the issues at hand (So ignore this if its stupid), but doesn't the relevant rfc say language codes are entirely case-insensitive, so shouldn't we accept them in any case, not just all-lowercase and half-uppercase?

#Comment by PhiLiP (talk | contribs)   03:54, 31 October 2010

squid regards XVO's "string-contains" as case-sensitive, so either we provide all possible language code which major browsers taked, or add a new method like "string-icontains" to XVO to identify case-insensitive strings.

Status & tagging log