r75690 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r75689‎ | r75690 | r75691 >
Date:22:42, 29 October 2010
Author:hashar
Status:deferred
Tags:
Comment:
Follow up r75682 : fix private function naming.
Fix cruise control build 2010-10-29T22:18:27
Modified paths:
  • /trunk/phase3/maintenance/tests/phpunit/includes/UserIsValidEmailAddrTest.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/tests/phpunit/includes/UserIsValidEmailAddrTest.php
@@ -2,7 +2,7 @@
33
44 class UserIsValidEmailAddrTest extends PHPUnit_Framework_TestCase {
55
6 - private function testEmail( $addr, $expected = true, $msg = '') {
 6+ private function checkEmail( $addr, $expected = true, $msg = '') {
77 $this->assertEquals(
88 $expected,
99 User::isValidEmailAddr( $addr ),
@@ -10,10 +10,10 @@
1111 );
1212 }
1313 private function valid( $addr, $msg = '' ) {
14 - $this->testEmail( $addr, true, $msg );
 14+ $this->checkEmail( $addr, true, $msg );
1515 }
1616 private function invalid( $addr, $msg = '' ) {
17 - $this->testEmail( $addr, false, $msg );
 17+ $this->checkEmail( $addr, false, $msg );
1818 }
1919
2020 function testEmailWellKnownUserAtHostDotTldAreValid() {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r75682Follow up r75627. Implements r75670 in PHP to validate emails....hashar22:03, 29 October 2010

Status & tagging log