r75689 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r75688‎ | r75689 | r75690 >
Date:22:42, 29 October 2010
Author:reedy
Status:deferred
Tags:
Comment:
Mark a couple of methods static

Change a couple of static calls to non static functions to $this->
Modified paths:
  • /trunk/extensions/Collection/Collection.suggest.php (modified) (history)
  • /trunk/extensions/ReaderFeedback/specialpages/RatingHistory_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Collection/Collection.suggest.php
@@ -51,7 +51,7 @@
5252 * or a number of articles to add or a value (1 - 1.5) all articles with a
5353 * higher value will be added to the collection
5454 */
55 - public function run( $mode = '', $param = '' ) {
 55+ public static function run( $mode = '', $param = '' ) {
5656 global $wgOut;
5757
5858 if ( !CollectionSession::hasSession() ) {
Index: trunk/extensions/ReaderFeedback/specialpages/RatingHistory_body.php
@@ -547,7 +547,7 @@
548548 */
549549 public function getFilePath( $tag, $ext='' ) {
550550 global $wgUploadDirectory;
551 - $rel = self::getRelPath( $tag, $ext );
 551+ $rel = $this->getRelPath( $tag, $ext );
552552 return "{$wgUploadDirectory}/graphs/{$rel}";
553553 }
554554
@@ -559,7 +559,7 @@
560560 */
561561 public function getUrlPath( $tag, $ext='' ) {
562562 global $wgUploadPath;
563 - $rel = self::getRelPath( $tag, $ext );
 563+ $rel = $this->getRelPath( $tag, $ext );
564564 return "{$wgUploadPath}/graphs/{$rel}";
565565 }
566566

Status & tagging log