r75655 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r75654‎ | r75655 | r75656 >
Date:17:41, 29 October 2010
Author:aaron
Status:deferred (Comments)
Tags:
Comment:
Make this wmf-depl compatible
Modified paths:
  • /trunk/extensions/FlaggedRevs/forms/RevisionReviewForm.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/forms/RevisionReviewForm.php
——@@ -1047,7 +1047,7 @@
10481048 $defaultSummary = wfMsg( 'revreview-reject-default-summary',
10491049 $newRev->getUserText(), $oldRev->getId(), $oldRev->getUserText() );
10501050
1051 - $form = Html::openElement( 'form',
 1051+ $form = Xml::openElement( 'form',
10521052 array( 'method' => 'POST', 'action' => $thisPage->getFullUrl() )
10531053 );
10541054 $form .= Html::hidden( 'action', 'reject' );
——@@ -1062,7 +1062,7 @@
10631063 $form .= Html::input( 'wpSubmit', wfMsg( 'revreview-reject-confirm' ), 'submit' );
10641064 $form .= Html::input( 'wpCancel', wfMsg( 'revreview-reject-cancel' ),
10651065 'button', array( 'onClick' => 'history.back();' ) );
1066 - $form .= Html::closeElement( 'form' );
 1066+ $form .= Xml::closeElement( 'form' );
10671067 $wgOut->addHtml( $form );
10681068 }
10691069

Comments

#Comment by 😂 (talk | contribs)   17:31, 30 October 2010

This shouldn't be necessary, Html has been deployed.

#Comment by Aaron Schulz (talk | contribs)   17:38, 30 October 2010

closeElement() has not (not sure why though)

#Comment by 😂 (talk | contribs)   17:40, 30 October 2010
  • sigh* Ok :)

Status & tagging log