r75651 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r75650‎ | r75651 | r75652 >
Date:16:41, 29 October 2010
Author:demon
Status:deferred
Tags:
Comment:
MFT r75650
Modified paths:
  • /branches/REL1_16/phase3/maintenance (modified) (history)
  • /branches/REL1_16/phase3/maintenance/Maintenance.php (modified) (history)
  • /branches/REL1_16/phase3/maintenance/generateSitemap.php (modified) (history)

Diff [purge]

Index: branches/REL1_16/phase3/maintenance/generateSitemap.php
@@ -131,9 +131,6 @@
132132 $this->mDescription = "Creates a sitemap for the site";
133133 $this->addOption( 'fspath', 'The file system path to save to, e.g. /tmp/sitemap' .
134134 "\n\t\tdefaults to current directory", false, true );
135 - $this->addOption( 'server', "The protocol and server name to use in URLs, e.g.\n" .
136 - "\t\thttp://en.wikipedia.org. This is sometimes necessary because\n" .
137 - "\t\tserver name detection may fail in command line scripts.", false, true );
138135 $this->addOption( 'compress', 'Compress the sitemap files, can take value yes|no, default yes', false, true );
139136 }
140137
Index: branches/REL1_16/phase3/maintenance/Maintenance.php
@@ -312,6 +312,9 @@
313313 $this->addOption( 'conf', "Location of LocalSettings.php, if not default", false, true );
314314 $this->addOption( 'wiki', "For specifying the wiki ID", false, true );
315315 $this->addOption( 'globals', "Output globals at the end of processing for debugging" );
 316+ $this->addOption( 'server', "The protocol and server name to use in URLs, e.g.\n" .
 317+ "\t\thttp://en.wikipedia.org. This is sometimes necessary because\n" .
 318+ "\t\tserver name detection may fail in command line scripts.", false, true );
316319 // If we support a DB, show the options
317320 if( $this->getDbType() > 0 ) {
318321 $this->addOption( 'dbuser', "The DB user to use for this script", false, true );
@@ -612,7 +615,7 @@
613616 * Handle some last-minute setup here.
614617 */
615618 public function finalSetup() {
616 - global $wgCommandLineMode, $wgShowSQLErrors;
 619+ global $wgCommandLineMode, $wgShowSQLErrors, $wgServer;
617620 global $wgTitle, $wgProfiling, $IP, $wgDBadminuser, $wgDBadminpassword;
618621 global $wgDBuser, $wgDBpassword, $wgDBservers, $wgLBFactoryConf;
619622
@@ -623,6 +626,11 @@
624627 # Same with these
625628 $wgCommandLineMode = true;
626629
 630+ # Override $wgServer
 631+ if( $this->hasOption( 'server') ) {
 632+ $wgServer = $this->getOption( 'server', $wgServer );
 633+ }
 634+
627635 # If these were passed, use them
628636 if( $this->mDbUser )
629637 $wgDBadminuser = $this->mDbUser;
Property changes on: branches/REL1_16/phase3/maintenance/Maintenance.php
___________________________________________________________________
Modified: svn:mergeinfo
630638 Merged /trunk/phase3/maintenance/Maintenance.php:r75650
Property changes on: branches/REL1_16/phase3/maintenance
___________________________________________________________________
Added: svn:mergeinfo
631639 Merged /trunk/phase3/maintenance:r63545-63546,63549,63643,63764,63897-63901,64876,75650

Follow-up revisions

RevisionCommit summaryAuthorDate
r75652Release notes for r75651maxsem17:05, 29 October 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r75650(bug 19593) $wgServer can't be set properly with --server attribute in comman...demon16:28, 29 October 2010

Status & tagging log