r75636 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r75635‎ | r75636 | r75637 >
Date:23:56, 28 October 2010
Author:awjrichards
Status:deferred
Tags:
Comment:
Changed ensure session to static method
Modified paths:
  • /trunk/extensions/DonationInterface/payflowpro_gateway/payflowpro_gateway.body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/payflowpro_gateway/payflowpro_gateway.body.php
@@ -862,7 +862,7 @@
863863 public static function fnPayflowEditToken( $salt='' ) {
864864
865865 // make sure we have a session open for tracking a CSRF-prevention token
866 - $this->fnPayflowEnsureSession();
 866+ self::fnPayflowEnsureSession();
867867
868868 if ( !isset( $_SESSION[ 'payflowEditToken' ] )) {
869869 //generate unsalted token to place in the session
@@ -918,7 +918,7 @@
919919 * If we do not have a session set for the current user,
920920 * start the session.
921921 */
922 - public function fnPayflowEnsureSession() {
 922+ public static function fnPayflowEnsureSession() {
923923 // if the session is already started, do nothing
924924 if ( session_id() ) return;
925925

Follow-up revisions

RevisionCommit summaryAuthorDate
r75657New deployment branch created from r75636 of trunkawjrichards18:16, 29 October 2010

Status & tagging log