r75613 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r75612‎ | r75613 | r75614 >
Date:14:38, 28 October 2010
Author:catrope
Status:ok (Comments)
Tags:
Comment:
Some message documentation for sign-off stuff in CodeReview. Also correct the notion that a sign-off implies total authority: that's explicitly NOT what this feature is for.
Modified paths:
  • /trunk/extensions/CodeReview/CodeReview.i18n.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/CodeReview.i18n.php
@@ -245,12 +245,16 @@
246246 'code-status-new' => '{{Identical|New}}',
247247 'code-status-reverted' => '{{Identical|Revert}}',
248248 'code-status-ok' => '{{Identical|OK}}',
249 - 'code-signoffs' => 'A "sign-off" is a concept in code review that means that the person doing the sign-off has the authority to completely approve the involved code changes and has done so.',
250 - 'code-signoff-legend' => 'A "sign-off" is a concept in code review that means that the person doing the sign-off has the authority to completely approve the involved code changes and has done so.',
 249+ 'code-signoffs' => 'A "sign-off" is a concept in code review that means that the person doing the sign-off has approved the involved code changes.',
 250+ 'code-signoff-legend' => 'A "sign-off" is a concept in code review that means that the person doing the sign-off has approved the involved code changes.',
251251 'code-signoff-submit' => 'Submit button text.
252252
253 -A "sign-off" is a concept in code review that means that the person doing the sign-off has the authority to completely approve the involved code changes and has done so.',
254 - 'code-signoff-field-date' => '{{Identical|Date}}',
 253+A "sign-off" is a concept in code review that means that the person doing the sign-off has approved the involved code changes.',
 254+ 'code-signoff-flag-inspected' => 'Type of sign-off indicating the code has been looked at.',
 255+ 'code-signoff-flag-tested' => 'Type of sign-off indicating the code has been tested.',
 256+ 'code-signoff-field-user' => 'Table column header: name of the user that did the sign-off.',
 257+ 'code-signoff-field-flag' => 'Table column header: "type" of sign-off. One of the code-signoff-flag-* messages.',
 258+ 'code-signoff-field-date' => 'Table column header: timestamp of the sign-off. {{Identical|Date}}',
255259 'code-pathsearch-path' => '{{Identical|Path}}',
256260 'code-revfilter-cr_status' => '{{Identical|Status}}',
257261 'code-revfilter-cr_author' => '{{Identical|Author}}',
@@ -293,7 +297,7 @@
294298 'right-codereview-remove-tag' => '{{doc-right}}',
295299 'right-codereview-post-comment' => '{{doc-right}}',
296300 'right-codereview-set-status' => '{{doc-right}}',
297 - 'right-codereview-signoff' => 'A "sign-off" is a concept in code review that means that the person doing the sign-off has the authority to completely approve the involved code changes and has done so.',
 301+ 'right-codereview-signoff' => 'A "sign-off" is a concept in code review that means that the person doing the sign-off has approved the involved code changes.',
298302 'right-codereview-link-user' => '{{Doc-right}}',
299303 );
300304

Comments

#Comment by Siebrand (talk | contribs)   18:44, 28 October 2010

Definition was checked with Danese at #mwhack :).

Status & tagging log