r75589 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r75588‎ | r75589 | r75590 >
Date:22:27, 27 October 2010
Author:platonides
Status:ok (Comments)
Tags:
Comment:
Do NOT use hardcoded passwords! Not even if the user agreed to run destructive tests.
The affected passwords have been disabled in r75588

Follow up r72475,r74213.
Additionally give descriptive names to the users.

Also see the mail to wikitech.
Modified paths:
  • /trunk/phase3/maintenance/tests/phpunit/includes/api/ApiSetup.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/tests/phpunit/includes/api/ApiSetup.php
@@ -33,8 +33,8 @@
3434
3535 static function setupUser() {
3636 if ( self::$user == null || self::$sysopUser == null ) {
37 - self::$user = new UserWrapper( 'Useruser', 'Passpass' );
38 - self::$sysopUser = new UserWrapper( 'Useruser1', 'Passpass1', 'sysop' );
 37+ self::$user = new UserWrapper( 'User for MediaWiki automated tests', User::randomPassword() );
 38+ self::$sysopUser = new UserWrapper( 'Sysop for MediaWiki automated tests', User::randomPassword(), 'sysop' );
3939 }
4040
4141 $GLOBALS['wgUser'] = self::$sysopUser->user;
@@ -67,3 +67,4 @@
6868 $this->user->saveSettings();
6969 }
7070 }
 71+

Follow-up revisions

RevisionCommit summaryAuthorDate
r75605fix so we do not create users with guessable passwords, viz r75589neilk04:40, 28 October 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r72475Follow-up r70137: Made asynchronous upload working a bit more. It now fully w...btongminh10:18, 6 September 2010
r74213Revert r74122, making r74117 live again...reedy15:24, 3 October 2010
r75588Add feature to block common (weak) passwords....platonides22:26, 27 October 2010

Comments

#Comment by Bryan (talk | contribs)   20:16, 16 December 2010

My apologies for this mess.

#Comment by Platonides (talk | contribs)   21:20, 16 December 2010

Apologies accepted :)

Status & tagging log