r75548 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r75547‎ | r75548 | r75549 >
Date:15:21, 27 October 2010
Author:catrope
Status:ok
Tags:
Comment:
Followup r74966, r75006: load $wgHandheldStyle again in SkinMonoBook. Can't do this the nice way (with ResourceLoader) because $wgHandheldStyle might be a URL :(
Modified paths:
  • /trunk/phase3/skins/MonoBook.php (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/MonoBook.php
@@ -28,6 +28,12 @@
2929
3030 $out->addModuleStyles( 'skins.monobook' );
3131
 32+ // Ugh. Can't do this properly because $wgHandheldStyle may be a URL
 33+ if( $wgHandheldStyle ) {
 34+ // Currently in testing... try 'chick/main.css'
 35+ $out->addStyle( $wgHandheldStyle, 'handheld' );
 36+ }
 37+
3238 // TODO: Migrate all of these
3339 //$out->addStyle( 'monobook/IE50Fixes.css', 'screen', 'lt IE 5.5000' );
3440 //$out->addStyle( 'monobook/IE55Fixes.css', 'screen', 'IE 5.5000' );

Follow-up revisions

RevisionCommit summaryAuthorDate
r75551Followup r75548: forgot to put global $wgHandheldStyle; back incatrope15:30, 27 October 2010
r781751.17: Back out Monobook-to-ResourceLoader port, has issues on IE6. This rever...catrope11:53, 10 December 2010
r80778Removing commented wgHandheldStyle in Resources.php + wrapping lines at 80 (o...krinkle23:17, 22 January 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r74966First shot at porting Monobook to Vector. The only non-straightforward part i...catrope20:35, 18 October 2010
r75006Temp fix for r74966 to stop causing errors everywherenikerabbit08:27, 19 October 2010

Status & tagging log