r75540 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r75539‎ | r75540 | r75541 >
Date:13:56, 27 October 2010
Author:platonides
Status:ok (Comments)
Tags:
Comment:
Follow up r75474
Modified paths:
  • /trunk/phase3/maintenance/update.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/update.php
@@ -3,6 +3,7 @@
44 * Run all updaters.
55 *
66 * This is used when the database schema is modified and we need to apply patches.
 7+ * It is kept compatible with php 4 parsing so that it can give out a meaningful error.
78 *
89 * @file
910 * @todo document
@@ -30,7 +31,7 @@
3132 }
3233
3334 function getDbType() {
34 - return DB_ADMIN;
 35+ return 2 /* Maintenance::DB_ADMIN */;
3536 }
3637
3738 function execute() {

Follow-up revisions

RevisionCommit summaryAuthorDate
r75543r75540 CRplatonides14:46, 27 October 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r75474Keep maintenance/update.php php4 compatible up to the point where we can give...platonides21:42, 26 October 2010

Comments

#Comment by Catrope (talk | contribs)   14:01, 27 October 2010

Would be nice to explicitly mention PHP 4 parsing compat near the return 2; statement.

#Comment by Platonides (talk | contribs)   14:47, 27 October 2010

Done in r75543.

Status & tagging log