r75527 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r75526‎ | r75527 | r75528 >
Date:12:11, 27 October 2010
Author:reedy
Status:deferred
Tags:
Comment:
Fix a couple more uses of extract()
Modified paths:
  • /trunk/extensions/LiquidThreads/classes/ParserFunctions.php (modified) (history)

Diff [purge]

Index: trunk/extensions/LiquidThreads/classes/ParserFunctions.php
@@ -98,7 +98,10 @@
9999 }
100100
101101 static function runLqtTalkPage( $details ) {
102 - extract($details);
 102+ $title = $details["title"];
 103+ $article = $details["article"];
 104+ $talkpage = $details["talkpage"];
 105+ $args = $details["args"];
103106
104107 global $wgUser, $wgRequest, $wgOut;
105108 $oldOut = $wgOut->getHTML();
@@ -125,7 +128,8 @@
126129 }
127130
128131 static function showLqtThread( $details ) {
129 - extract($details);
 132+ $title = $details["title"];
 133+ $article = $details["article"];
130134
131135 global $wgUser, $wgRequest, $wgOut;
132136 $oldOut = $wgOut->getHTML();

Status & tagging log