r75528 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r75527‎ | r75528 | r75529 >
Date:12:17, 27 October 2010
Author:reedy
Status:deferred
Tags:
Comment:
Remove a few unused arrays. Add a couple of braces. Add missing parameter to wfDebugLog
Modified paths:
  • /trunk/extensions/LiquidThreads/api/ApiQueryLQTThreads.php (modified) (history)
  • /trunk/extensions/LiquidThreads/classes/DeletionController.php (modified) (history)
  • /trunk/extensions/LiquidThreads/classes/Thread.php (modified) (history)

Diff [purge]

Index: trunk/extensions/LiquidThreads/classes/DeletionController.php
@@ -12,7 +12,7 @@
1313 $threads = Threads::where( array( 'thread_root' => $id ) );
1414
1515 if ( !count( $threads ) ) {
16 - wfDebugLog( __METHOD__ . ": no threads with root $id, ignoring...\n" );
 16+ wfDebugLog( 'LiquidThreads', __METHOD__ . ": no threads with root $id, ignoring...\n" );
1717 return true;
1818 }
1919
Index: trunk/extensions/LiquidThreads/classes/Thread.php
@@ -790,7 +790,9 @@
791791 // This is an invocation guard to avoid infinite recursion when fixing a
792792 // missing ancestor.
793793 static $doingUpdates = false;
794 - if ( $doingUpdates ) return;
 794+ if ( $doingUpdates ) {
 795+ return;
 796+ }
795797 $doingUpdates = true;
796798
797799 // Fix missing ancestry information.
Index: trunk/extensions/LiquidThreads/api/ApiQueryLQTThreads.php
@@ -203,11 +203,9 @@
204204 $nsField = $fields['namespace'];
205205 $tField = $fields['title'];
206206 $title = Title::makeTitle( $row->$nsField, $row->$tField );
207 - $result = array();
208207 ApiQueryBase::addTitleInfo( $entry, $title, 'page' );
209208 } else {
210209 // Complicated case.
211 - $result = array();
212210 foreach ( $fields as $part => $field ) {
213211 $entry[$name][$part] = $row->$field;
214212 }

Status & tagging log