r75510 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r75509‎ | r75510 | r75511 >
Date:10:55, 27 October 2010
Author:reedy
Status:ok (Comments)
Tags:
Comment:
Minor revert to r75485, add back some actually used variables used using 3442foo
Modified paths:
  • /trunk/extensions/Translate/TranslatePage.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/TranslatePage.php
@@ -193,6 +193,11 @@
194194 protected function settingsForm( $errors ) {
195195 global $wgScript;
196196
 197+ $task = $this->taskSelector();
 198+ $group = $this->groupSelector();
 199+ $language = $this->languageSelector();
 200+ $limit = $this->limitSelector();
 201+
197202 $button = Xml::submitButton( wfMsg( 'translate-submit' ) );
198203
199204 $options = array();

Follow-up revisions

RevisionCommit summaryAuthorDate
r75512For r75510, add a comment marking them used as black magic per Nikerabbitreedy11:04, 27 October 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r75485Remove unused variables, few other tweaks and bits and piecesreedy23:02, 26 October 2010

Comments

#Comment by Nikerabbit (talk | contribs)   11:00, 27 October 2010

Can you please add a comment too, since this is not the first time this has happened.

Status & tagging log