r75491 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r75490‎ | r75491 | r75492 >
Date:00:16, 27 October 2010
Author:tparscal
Status:ok (Comments)
Tags:
Comment:
Mostly reverted r75487, making use of a new version of mediaWiki.msg.
Modified paths:
  • /trunk/extensions/ProofreadPage/proofread.js (modified) (history)
  • /trunk/extensions/Vector/modules/ext.vector.editWarning.js (modified) (history)
  • /trunk/extensions/Vector/modules/ext.vector.simpleSearch.js (modified) (history)
  • /trunk/extensions/WikiEditor/modules/ext.wikiEditor.dialogs.js (modified) (history)
  • /trunk/extensions/WikiEditor/modules/jquery.wikiEditor.dialogs.js (modified) (history)
  • /trunk/extensions/WikiEditor/modules/jquery.wikiEditor.js (modified) (history)
  • /trunk/extensions/WikiEditor/modules/jquery.wikiEditor.preview.js (modified) (history)
  • /trunk/extensions/WikiEditor/modules/jquery.wikiEditor.publish.js (modified) (history)
  • /trunk/extensions/WikiEditor/modules/jquery.wikiEditor.templateEditor.js (modified) (history)
  • /trunk/extensions/WikiEditor/modules/jquery.wikiEditor.toc.js (modified) (history)
  • /trunk/phase3/resources/mediawiki/mediawiki.js (modified) (history)
  • /trunk/phase3/skins/common/ajaxwatch.js (modified) (history)
  • /trunk/phase3/skins/common/wikibits.js (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/common/ajaxwatch.js
@@ -12,17 +12,17 @@
1313 if ( action == 'watch' || action == 'unwatch' ) {
1414 // save the accesskey from the title
1515 var keyCommand = $link.attr( 'title' ).match( /\[.*?\]$/ ) ? $link.attr( 'title' ).match( /\[.*?\]$/ )[0] : '';
16 - $link.attr( 'title', mediaWiki.message( 'tooltip-ca-' + action ) + ' ' + keyCommand );
 16+ $link.attr( 'title', mediaWiki.msg( 'tooltip-ca-' + action ) + ' ' + keyCommand );
1717 }
1818 if ( $link.data( 'icon' ) ) {
19 - $link.attr( 'alt', mediaWiki.message( action ) );
 19+ $link.attr( 'alt', mediaWiki.msg( action ) );
2020 if ( action == 'watching' || action == 'unwatching' ) {
2121 $link.addClass( 'loading' );
2222 } else {
2323 $link.removeClass( 'loading' );
2424 }
2525 } else {
26 - $link.html( mediaWiki.message( action ) );
 26+ $link.html( mediaWiki.msg( action ) );
2727 }
2828 };
2929
@@ -110,7 +110,7 @@
111111 if( $link.parents( 'li' ).attr( 'id' ) == 'ca-' + action ) {
112112 $link.parents( 'li' ).attr( 'id', 'ca-' + otheraction );
113113 // update the link text with the new message
114 - $link.text( mediaWiki.message( otheraction ) );
 114+ $link.text( mediaWiki.msg( otheraction ) );
115115 }
116116 };
117117 return false;
Index: trunk/phase3/skins/common/wikibits.js
@@ -156,7 +156,7 @@
157157 toggleLink.href = '#';
158158 addClickHandler( toggleLink, function( evt ) { toggleToc(); return killEvt( evt ); } );
159159
160 - toggleLink.appendChild( document.createTextNode( mediaWiki.message( 'hidetoc' ) ) );
 160+ toggleLink.appendChild( document.createTextNode( mediaWiki.msg( 'hidetoc' ) ) );
161161
162162 outerSpan.appendChild( document.createTextNode( '[' ) );
163163 outerSpan.appendChild( toggleLink );
@@ -198,12 +198,12 @@
199199 var toggleLink = document.getElementById( 'togglelink' );
200200
201201 if ( toc && toggleLink && toc.style.display == 'none' ) {
202 - changeText( toggleLink, mediaWiki.message( 'hidetoc' ) );
 202+ changeText( toggleLink, mediaWiki.msg( 'hidetoc' ) );
203203 toc.style.display = 'block';
204204 document.cookie = "hidetoc=0";
205205 tocmain.className = 'toc';
206206 } else {
207 - changeText( toggleLink, mediaWiki.message( 'showtoc' ) );
 207+ changeText( toggleLink, mediaWiki.msg( 'showtoc' ) );
208208 toc.style.display = 'none';
209209 document.cookie = "hidetoc=1";
210210 tocmain.className = 'toc tochidden';
Index: trunk/phase3/resources/mediawiki/mediawiki.js
@@ -142,7 +142,7 @@
143143 Message.prototype.toString = function() {
144144 if ( !this.map.exists( this.key ) ) {
145145 // Return <key> if key does not exist
146 - return '<' + key + '>';
 146+ return '<' + this.key + '>';
147147 }
148148 var text = this.map.get( this.key );
149149 var parameters = this.parameters;
@@ -246,7 +246,7 @@
247247 * replacement
248248 */
249249 this.msg = function( key, parameters ) {
250 - return mediaWiki.message.apply( mediaWiki.message, arguments );
 250+ return mediaWiki.message.apply( mediaWiki.message, arguments ).toString();
251251 };
252252
253253 /**
Index: trunk/extensions/WikiEditor/modules/jquery.wikiEditor.templateEditor.js
@@ -316,7 +316,7 @@
317317 </fieldset>',
318318 init: function() {
319319 $(this).find( '[rel]' ).each( function() {
320 - $(this).text( mediaWiki.message( $(this).attr( 'rel' ) ) );
 320+ $(this).text( mediaWiki.msg( $(this).attr( 'rel' ) ) );
321321 } );
322322 },
323323 dialog: {
Index: trunk/extensions/WikiEditor/modules/jquery.wikiEditor.dialogs.js
@@ -114,10 +114,10 @@
115115 configuration.title = $.wikiEditor.autoMsg( module, 'title' );
116116 // Transform messages in keys
117117 // Stupid JS won't let us do stuff like
118 - // foo = { mediaWiki.message( 'bar' ): baz }
 118+ // foo = { mediaWiki.msg( 'bar' ): baz }
119119 configuration.newButtons = {};
120120 for ( msg in configuration.buttons )
121 - configuration.newButtons[mediaWiki.message( msg )] = configuration.buttons[msg];
 121+ configuration.newButtons[mediaWiki.msg( msg )] = configuration.buttons[msg];
122122 configuration.buttons = configuration.newButtons;
123123 // Create the dialog <div>
124124 var dialogDiv = $( '<div />' )
Index: trunk/extensions/WikiEditor/modules/jquery.wikiEditor.js
@@ -115,7 +115,7 @@
116116 return false;
117117 },
118118 /**
119 - * Provides a way to extract messages from objects. Wraps the mediaWiki.message() function, which
 119+ * Provides a way to extract messages from objects. Wraps the mediaWiki.msg() function, which
120120 * may eventually become a wrapper for some kind of core MW functionality.
121121 *
122122 * @param object Object to extract messages from
@@ -139,9 +139,9 @@
140140 } else if ( property + 'Msg' in object ) {
141141 var p = object[property + 'Msg'];
142142 if ( $.isArray( p ) && p.length >= 2 ) {
143 - return mediaWiki.message.apply( p ).toString();
 143+ return mediaWiki.msg.apply( mediaWiki.msg, p );
144144 } else {
145 - return mediaWiki.message( p ).toString();
 145+ return mediaWiki.msg( p );
146146 }
147147 } else {
148148 return '';
@@ -542,7 +542,7 @@
543543 /* Disabling our loading div for now
544544 var $loader = $( '<div></div>' )
545545 .addClass( 'wikiEditor-ui-loading' )
546 - .append( $( '<span>' + mediaWiki.message( 'wikieditor-loading' ) + '</span>' )
 546+ .append( $( '<span>' + mediaWiki.msg( 'wikieditor-loading' ) + '</span>' )
547547 .css( 'marginTop', context.$textarea.height() / 2 ) );
548548 */
549549 // Encapsulate the textarea with some containers for layout
Index: trunk/extensions/WikiEditor/modules/ext.wikiEditor.dialogs.js
@@ -221,18 +221,18 @@
222222 });
223223 // Set labels of tabs based on rel values
224224 $(this).find( '[rel]' ).each( function() {
225 - $(this).text( mediaWiki.message( $(this).attr( 'rel' ) ) );
 225+ $(this).text( mediaWiki.msg( $(this).attr( 'rel' ) ) );
226226 });
227227 // Set tabindexes on form fields
228228 $.wikiEditor.modules.dialogs.fn.setTabindexes( $(this).find( 'input' ).not( '[tabindex]' ) );
229229 // Setup the tooltips in the textboxes
230230 $( '#wikieditor-toolbar-link-int-target' )
231 - .data( 'tooltip', mediaWiki.message( 'wikieditor-toolbar-tool-link-int-target-tooltip' ) );
 231+ .data( 'tooltip', mediaWiki.msg( 'wikieditor-toolbar-tool-link-int-target-tooltip' ) );
232232 $( '#wikieditor-toolbar-link-int-text' )
233 - .data( 'tooltip', mediaWiki.message( 'wikieditor-toolbar-tool-link-int-text-tooltip' ) );
 233+ .data( 'tooltip', mediaWiki.msg( 'wikieditor-toolbar-tool-link-int-text-tooltip' ) );
234234 $( '#wikieditor-toolbar-link-int-target, #wikieditor-toolbar-link-int-text' )
235235 .each( function() {
236 - var tooltip = mediaWiki.message( $( this ).attr( 'id' ) + '-tooltip' );
 236+ var tooltip = mediaWiki.msg( $( this ).attr( 'id' ) + '-tooltip' );
237237 if ( $( this ).val() == '' )
238238 $( this )
239239 .addClass( 'wikieditor-toolbar-dialog-hint' )
@@ -301,11 +301,11 @@
302302 });
303303 // Add images to the page existence widget, which will be shown mutually exclusively to communicate if
304304 // the page exists, does not exist or the title is invalid (like if it contains a | character)
305 - var existsMsg = mediaWiki.message( 'wikieditor-toolbar-tool-link-int-target-status-exists' );
306 - var notexistsMsg = mediaWiki.message( 'wikieditor-toolbar-tool-link-int-target-status-notexists' );
307 - var invalidMsg = mediaWiki.message( 'wikieditor-toolbar-tool-link-int-target-status-invalid' );
308 - var externalMsg = mediaWiki.message( 'wikieditor-toolbar-tool-link-int-target-status-external' );
309 - var loadingMsg = mediaWiki.message( 'wikieditor-toolbar-tool-link-int-target-status-loading' );
 305+ var existsMsg = mediaWiki.msg( 'wikieditor-toolbar-tool-link-int-target-status-exists' );
 306+ var notexistsMsg = mediaWiki.msg( 'wikieditor-toolbar-tool-link-int-target-status-notexists' );
 307+ var invalidMsg = mediaWiki.msg( 'wikieditor-toolbar-tool-link-int-target-status-invalid' );
 308+ var externalMsg = mediaWiki.msg( 'wikieditor-toolbar-tool-link-int-target-status-external' );
 309+ var loadingMsg = mediaWiki.msg( 'wikieditor-toolbar-tool-link-int-target-status-loading' );
310310 $( '#wikieditor-toolbar-link-int-target-status' )
311311 .append( $( '<div />' )
312312 .attr( 'id', 'wikieditor-toolbar-link-int-target-status-exists' )
@@ -423,7 +423,7 @@
424424 if ( $( '#wikieditor-toolbar-link-int-text' ).data( 'tooltip-mode' ) )
425425 text = "";
426426 if ( target == '' ) {
427 - alert( mediaWiki.message( 'wikieditor-toolbar-tool-link-empty' ) );
 427+ alert( mediaWiki.msg( 'wikieditor-toolbar-tool-link-empty' ) );
428428 return;
429429 }
430430 if ( $.trim( text ) == '' ) {
@@ -435,7 +435,7 @@
436436 // FIXME: Exactly how fragile is this?
437437 if ( $( '#wikieditor-toolbar-link-int-target-status-invalid' ).is( ':visible' ) ) {
438438 // Refuse to add links to invalid titles
439 - alert( mediaWiki.message( 'wikieditor-toolbar-tool-link-int-invalid' ) );
 439+ alert( mediaWiki.msg( 'wikieditor-toolbar-tool-link-int-invalid' ) );
440440 return;
441441 }
442442
@@ -453,12 +453,12 @@
454454 if ( match && !$(this).data( 'ignoreLooksInternal' ) ) {
455455 var buttons = { };
456456 var that = this;
457 - buttons[ mediaWiki.message( 'wikieditor-toolbar-tool-link-lookslikeinternal-int' ) ] =
 457+ buttons[ mediaWiki.msg( 'wikieditor-toolbar-tool-link-lookslikeinternal-int' ) ] =
458458 function() {
459459 $( '#wikieditor-toolbar-link-int-target' ).val( match[1] ).change();
460460 $(this).dialog( 'close' );
461461 };
462 - buttons[ mediaWiki.message( 'wikieditor-toolbar-tool-link-lookslikeinternal-ext' ) ] =
 462+ buttons[ mediaWiki.msg( 'wikieditor-toolbar-tool-link-lookslikeinternal-ext' ) ] =
463463 function() {
464464 $(that).data( 'ignoreLooksInternal', true );
465465 $(that).closest( '.ui-dialog' ).find( 'button:first' ).click();
@@ -466,7 +466,7 @@
467467 $(this).dialog( 'close' );
468468 };
469469 $.wikiEditor.modules.dialogs.quickDialog(
470 - mediaWiki.message( 'wikieditor-toolbar-tool-link-lookslikeinternal', match[1] ),
 470+ mediaWiki.msg( 'wikieditor-toolbar-tool-link-lookslikeinternal', match[1] ),
471471 { buttons: buttons }
472472 );
473473 return;
@@ -615,7 +615,7 @@
616616 init: function() {
617617 // Insert translated strings into labels
618618 $( this ).find( '[rel]' ).each( function() {
619 - $( this ).text( mediaWiki.message( $( this ).attr( 'rel' ) ) );
 619+ $( this ).text( mediaWiki.msg( $( this ).attr( 'rel' ) ) );
620620 } );
621621
622622 },
@@ -759,7 +759,7 @@
760760 </div></div>',
761761 init: function() {
762762 $(this).find( '[rel]' ).each( function() {
763 - $(this).text( mediaWiki.message( $(this).attr( 'rel' ) ) );
 763+ $(this).text( mediaWiki.msg( $(this).attr( 'rel' ) ) );
764764 });
765765 // Set tabindexes on form fields
766766 $.wikiEditor.modules.dialogs.fn.setTabindexes( $(this).find( 'input' ).not( '[tabindex]' ) );
@@ -820,19 +820,19 @@
821821 var cols = parseInt( colsVal, 10 );
822822 var header = $( '#wikieditor-toolbar-table-dimensions-header' ).is( ':checked' ) ? 1 : 0;
823823 if ( isNaN( rows ) || isNaN( cols ) || rows != rowsVal || cols != colsVal ) {
824 - alert( mediaWiki.message( 'wikieditor-toolbar-tool-table-invalidnumber' ) );
 824+ alert( mediaWiki.msg( 'wikieditor-toolbar-tool-table-invalidnumber' ) );
825825 return;
826826 }
827827 if ( rows + header == 0 || cols == 0 ) {
828 - alert( mediaWiki.message( 'wikieditor-toolbar-tool-table-zero' ) );
 828+ alert( mediaWiki.msg( 'wikieditor-toolbar-tool-table-zero' ) );
829829 return;
830830 }
831831 if ( rows * cols > 1000 ) {
832 - alert( mediaWiki.message( 'wikieditor-toolbar-tool-table-toomany', 1000 ) );
 832+ alert( mediaWiki.msg( 'wikieditor-toolbar-tool-table-toomany', 1000 ) );
833833 return;
834834 }
835 - var headerText = mediaWiki.message( 'wikieditor-toolbar-tool-table-example-header' );
836 - var normalText = mediaWiki.message( 'wikieditor-toolbar-tool-table-example' );
 835+ var headerText = mediaWiki.msg( 'wikieditor-toolbar-tool-table-example-header' );
 836+ var normalText = mediaWiki.msg( 'wikieditor-toolbar-tool-table-example' );
837837 var table = "";
838838 for ( var r = 0; r < rows + header; r++ ) {
839839 table += "|-\n";
@@ -956,7 +956,7 @@
957957 </fieldset>',
958958 init: function() {
959959 $(this).find( '[rel]' ).each( function() {
960 - $(this).text( mediaWiki.message( $(this).attr( 'rel' ) ) );
 960+ $(this).text( mediaWiki.msg( $(this).attr( 'rel' ) ) );
961961 });
962962 // Set tabindexes on form fields
963963 $.wikiEditor.modules.dialogs.fn.setTabindexes( $(this).find( 'input' ).not( '[tabindex]' ) );
@@ -986,7 +986,7 @@
987987 var regex = new RegExp( searchStr, flags );
988988 } catch( e ) {
989989 $( '#wikieditor-toolbar-replace-invalidregex' )
990 - .text( mediaWiki.message( 'wikieditor-toolbar-tool-replace-invalidregex',
 990+ .text( mediaWiki.msg( 'wikieditor-toolbar-tool-replace-invalidregex',
991991 e.message ) )
992992 .show();
993993 return;
@@ -1040,7 +1040,7 @@
10411041 offset = newEnd;
10421042 }
10431043 $( '#wikieditor-toolbar-replace-success' )
1044 - .text( mediaWiki.message( 'wikieditor-toolbar-tool-replace-success', match.length ) )
 1044+ .text( mediaWiki.msg( 'wikieditor-toolbar-tool-replace-success', match.length ) )
10451045 .show();
10461046 $(this).data( 'offset', 0 );
10471047 } else {
Index: trunk/extensions/WikiEditor/modules/jquery.wikiEditor.publish.js
@@ -63,7 +63,7 @@
6464 </div>',
6565 init: function() {
6666 $(this).find( '[rel]' ).each( function() {
67 - $(this).text( mediaWiki.message( $(this).attr( 'rel' ) ) );
 67+ $(this).text( mediaWiki.msg( $(this).attr( 'rel' ) ) );
6868 });
6969
7070 /* REALLY DIRTY HACK! */
Index: trunk/extensions/WikiEditor/modules/jquery.wikiEditor.preview.js
@@ -134,7 +134,7 @@
135135 }
136136 } );
137137
138 - var loadingMsg = mediaWiki.message( 'wikieditor-preview-loading' );
 138+ var loadingMsg = mediaWiki.msg( 'wikieditor-preview-loading' );
139139 context.modules.preview.$preview
140140 .add( context.$changesTab )
141141 .append( $( '<div />' )
Index: trunk/extensions/WikiEditor/modules/jquery.wikiEditor.toc.js
@@ -510,7 +510,7 @@
511511 return false;
512512 } )
513513 .find( 'a' )
514 - .text( mediaWiki.message( 'wikieditor-toc-hide' ) );
 514+ .text( mediaWiki.msg( 'wikieditor-toc-hide' ) );
515515 $expandControl
516516 .addClass( 'wikiEditor-ui-toc-expandControl' )
517517 .append( '<a href="#" />' )
@@ -527,7 +527,7 @@
528528 } )
529529 .hide()
530530 .find( 'a' )
531 - .text( mediaWiki.message( 'wikieditor-toc-show' ) );
 531+ .text( mediaWiki.msg( 'wikieditor-toc-show' ) );
532532 $collapseControl.insertBefore( context.modules.toc.$toc );
533533 context.$ui.find( '.wikiEditor-ui-left .wikiEditor-ui-top' ).append( $expandControl );
534534 }
Index: trunk/extensions/Vector/modules/ext.vector.editWarning.js
@@ -35,7 +35,7 @@
3636 $( '#wpSummary' ).data( 'origtext' ) != $( '#wpSummary' ).val()
3737 ) {
3838 // Return our message
39 - retval = mediaWiki.message( 'vector-editwarning-warning' );
 39+ retval = mediaWiki.msg( 'vector-editwarning-warning' );
4040 }
4141 }
4242
Index: trunk/extensions/Vector/modules/ext.vector.simpleSearch.js
@@ -35,7 +35,7 @@
3636 }
3737
3838 // Placeholder text for SimpleSearch box
39 - $( 'div#simpleSearch > input#searchInput' ).placeholder( mediaWiki.message( 'vector-simplesearch-search' ) );
 39+ $( 'div#simpleSearch > input#searchInput' ).placeholder( mediaWiki.msg( 'vector-simplesearch-search' ) );
4040
4141 // General suggestions functionality for all search boxes
4242 $( '#searchInput, #searchInput2, #powerSearchText, #searchText' )
@@ -92,7 +92,7 @@
9393 $(this).show()
9494 $label = $( '<div />' )
9595 .addClass( 'special-label' )
96 - .text( mediaWiki.message( 'vector-simplesearch-containing' ).toString() )
 96+ .text( mediaWiki.msg( 'vector-simplesearch-containing' ) )
9797 .appendTo( $(this) );
9898 $query = $( '<div />' )
9999 .addClass( 'special-query' )
Index: trunk/extensions/ProofreadPage/proofread.js
@@ -51,7 +51,7 @@
5252 pageBody = text;
5353 pageFooter = proofreadPageFooter;
5454 if( document.editform ) {
55 - document.editform.elements['wpSummary'].value = '/* ' + mediaWiki.message( 'proofreadpage_quality1_category' ) + ' */ ';
 55+ document.editform.elements['wpSummary'].value = '/* ' + mediaWiki.msg( 'proofreadpage_quality1_category' ) + ' */ ';
5656 }
5757 }
5858 }
@@ -125,15 +125,15 @@
126126 container.innerHTML = '' +
127127 '<div id="prp_header" style="">' +
128128 '<span style="color:gray;font-size:80%;line-height:100%;">' +
129 - escapeQuotesHTML( mediaWiki.message( 'proofreadpage_header' ) ) + '</span>' +
 129+ escapeQuotesHTML( mediaWiki.msg( 'proofreadpage_header' ) ) + '</span>' +
130130 '<textarea name="wpHeaderTextbox" rows="2" cols="80" tabindex=1>' + pageHeader + '</textarea><br />' +
131131 '<span style="color:gray;font-size:80%;line-height:100%;">' +
132 - escapeQuotesHTML( mediaWiki.message( 'proofreadpage_body' ) ) + '</span></div>' +
 132+ escapeQuotesHTML( mediaWiki.msg( 'proofreadpage_body' ) ) + '</span></div>' +
133133 '<textarea name="wpTextbox1" id="wpTextbox1" tabindex=1 style="height:' + ( self.DisplayHeight - 6 ) + 'px;">' +
134134 pageBody + '</textarea>' +
135135 '<div id="prp_footer" style="">' +
136136 '<span style="color:gray;font-size:80%;line-height:100%;">' +
137 - escapeQuotesHTML( mediaWiki.message( 'proofreadpage_footer' ) ) + '</span><br />' +
 137+ escapeQuotesHTML( mediaWiki.msg( 'proofreadpage_footer' ) ) + '</span><br />' +
138138 '<textarea name="wpFooterTextbox" rows="2" cols="80" tabindex=1>' +
139139 pageFooter + '</textarea></div>';
140140 }
@@ -775,8 +775,8 @@
776776 image.className = 'mw-toolbar-editbutton';
777777 image.src = wgScriptPath + '/extensions/ProofreadPage/button_category_plus.png';
778778 image.border = 0;
779 - image.alt = mediaWiki.message( 'proofreadpage_toggleheaders' );
780 - image.title = mediaWiki.message( 'proofreadpage_toggleheaders' );
 779+ image.alt = mediaWiki.msg( 'proofreadpage_toggleheaders' );
 780+ image.title = mediaWiki.msg( 'proofreadpage_toggleheaders' );
781781 image.style.cursor = 'pointer';
782782 image.onclick = pr_toggle_visibility;
783783
@@ -919,19 +919,19 @@
920920 var text = '';
921921 switch( value ) {
922922 case 0:
923 - text = mediaWiki.message( 'proofreadpage_quality0_category' );
 923+ text = mediaWiki.msg( 'proofreadpage_quality0_category' );
924924 break;
925925 case 1:
926 - text = mediaWiki.message( 'proofreadpage_quality1_category' );
 926+ text = mediaWiki.msg( 'proofreadpage_quality1_category' );
927927 break;
928928 case 2:
929 - text = mediaWiki.message( 'proofreadpage_quality2_category' );
 929+ text = mediaWiki.msg( 'proofreadpage_quality2_category' );
930930 break;
931931 case 3:
932 - text = mediaWiki.message( 'proofreadpage_quality3_category' );
 932+ text = mediaWiki.msg( 'proofreadpage_quality3_category' );
933933 break;
934934 case 4:
935 - text = mediaWiki.message( 'proofreadpage_quality4_category' );
 935+ text = mediaWiki.msg( 'proofreadpage_quality4_category' );
936936 break;
937937 }
938938 form.elements['wpSummary'].value = '/* ' + text + ' */ ';
@@ -963,7 +963,7 @@
964964 +'<span class="quality1"> <input type="radio" name="quality" value=1 onclick="pr_add_quality(this.form,1)" tabindex=4> </span>'
965965 +'<span class="quality3"> <input type="radio" name="quality" value=3 onclick="pr_add_quality(this.form,3)" tabindex=4> </span>'
966966 +'<span class="quality4"> <input type="radio" name="quality" value=4 onclick="pr_add_quality(this.form,4)" tabindex=4> </span>';
967 - f.innerHTML = f.innerHTML + '&nbsp;' + escapeQuotesHTML( mediaWiki.message( 'proofreadpage_page_status' ) );
 967+ f.innerHTML = f.innerHTML + '&nbsp;' + escapeQuotesHTML( mediaWiki.msg( 'proofreadpage_page_status' ) );
968968
969969 if( !( ( self.proofreadpage_quality == 4 ) || ( ( self.proofreadpage_quality == 3 ) && ( self.proofreadpage_username != proofreadPageUserName ) ) ) ) {
970970 document.editform.quality[4].parentNode.style.cssText = 'display:none';

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r75487Updated use of mediaWiki.msg to mediaWiki.messagetparscal23:42, 26 October 2010

Comments

#Comment by Catrope (talk | contribs)   12:26, 27 October 2010
 
mediaWiki.msg.get is not a function (ext.vector.simpleSearch.js line 38)
$( 'div#simpleSearch > input#searchInput' ).placeholder( mediaWiki.msg.get( 'vector-simplesearch-search' ) );
#Comment by Trevor Parscal (WMF) (talk | contribs)   17:08, 27 October 2010

This isn't there anymore, as of r75491.

#Comment by Catrope (talk | contribs)   17:22, 27 October 2010

You're right, forgot to svn up extensions

Status & tagging log