r75477 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r75476‎ | r75477 | r75478 >
Date:22:21, 26 October 2010
Author:reedy
Status:ok (Comments)
Tags:
Comment:
Add break to switch in quickTags, otherwise they're just falling through...

Remove unused variable
Modified paths:
  • /trunk/extensions/FlaggedRevs/FlaggedRevs.class.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/FlaggedRevs.class.php
@@ -417,7 +417,6 @@
418418 # that the user is allowed to set...
419419 foreach ( self::getDimensions() as $qal => $levels ) {
420420 $level = isset( $flags[$qal] ) ? $flags[$qal] : 0;
421 - $highest = count( $levels ) - 1; // highest valid level
422421 if ( !self::userCanSetTag( $user, $qal, $level ) ) {
423422 return false; // user cannot set proposed flag
424423 } elseif ( isset( $oldflags[$qal] )
@@ -1180,8 +1179,10 @@
11811180 {
11821181 case FR_PRISTINE:
11831182 $minLevels = self::$minPL;
 1183+ break;
11841184 case FR_QUALITY:
11851185 $minLevels = self::$minQL;
 1186+ break;
11861187 default:
11871188 $minLevels = self::$minSL;
11881189 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r75507More tab/space fail from r75477reedy10:45, 27 October 2010

Comments

#Comment by Nikerabbit (talk | contribs)   10:41, 27 October 2010

Isn't break usually in the same level as the actual code, not with the case statement?

Status & tagging log