r75386 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r75385‎ | r75386 | r75387 >
Date:21:46, 25 October 2010
Author:demon
Status:ok (Comments)
Tags:
Comment:
Followup r75371, use MediaWiki default user and content language for messages
Modified paths:
  • /trunk/phase3/includes/installer/CoreInstaller.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/installer/CoreInstaller.php
@@ -440,11 +440,14 @@
441441 public function installMainpage( DatabaseInstaller &$installer ) {
442442 $status = Status::newGood();
443443 try {
444 - $titleobj = Title::newFromText( wfMsgNoDB( "mainpage" ) );
 444+ $titleobj = Title::newFromText( wfMsgForContent( "mainpage" ) );
445445 $article = new Article( $titleobj );
446 - $article->doEdit( wfMsg( 'mainpagetext' ) . "\n\n" . wfMsgNoTrans( 'mainpagedocfooter' ),
 446+ $article->doEdit( wfMsgForContent( 'mainpagetext' ) . "\n\n" .
 447+ wfMsgForContent( 'mainpagedocfooter' ),
447448 '',
448 - EDIT_NEW );
 449+ EDIT_NEW,
 450+ false,
 451+ User::newFromName( 'MediaWiki Default' ) );
449452 } catch (MWException $e) {
450453 //using raw, because $wgShowExceptionDetails can not be set yet
451454 $status->fatal( 'config-install-mainpage-failed', $e->getMessage() );

Follow-up revisions

RevisionCommit summaryAuthorDate
r75700Per r75386 CR, use newMainPage()demon17:47, 30 October 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r75371* moved installMainpage to CoreInstaller as requested in r75366freakolowsky18:57, 25 October 2010

Comments

#Comment by Umherirrender (talk | contribs)   17:54, 29 October 2010

There is Title::newMainPage().

Status & tagging log