r75364 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r75363‎ | r75364 | r75365 >
Date:16:28, 25 October 2010
Author:hashar
Status:ok (Comments)
Tags:
Comment:
Follow up r75361 : removing a work in progress test case
Modified paths:
  • /trunk/phase3/maintenance/tests/phpunit/includes/IPTest.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/tests/phpunit/includes/IPTest.php
——@@ -140,14 +140,4 @@
141141 $this->assertNet( '10.128.0.0' , '10.135.0.0/9' );
142142 $this->assertNet( '134.0.0.0' , '134.0.5.1/8' );
143143 }
144 -
145 - function testIPv6SpecialRanges() {
146 - $this->assertTrue( IPv6::isULA( 'fdc1:9d57:401e::' ) );
147 - $this->assertTrue( IPv6::isULA( 'FDC1:9D57:401E::' ) );
148 - $this->assertTrue( IPv6::isULA( 'fc::' ) );
149 - $this->assertTrue( IPv6::isULA( 'fdff:ffff:ffff::' ) );
150 -
151 - $this->assertFalse( IPv6::isULA( '2001:0DB8::A:1::' ) );
152 - $this->assertFalse( IPv6::isULA( '::1' ) );
153 - }
154144 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r75361* bypassers ($force, --help) moved to the top. Less error prone....hashar16:23, 25 October 2010

Comments

#Comment by Hashar (talk | contribs)   16:29, 25 October 2010

self marking this as 'ok' since it corrects unfinished code.

#Comment by Platonides (talk | contribs)   16:33, 25 October 2010

This is a partial revert, not a correction. If it was changing the code instead of reverting that function addition, you shouldn't self ok it.

Status & tagging log