r75329 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r75328‎ | r75329 | r75330 >
Date:18:33, 24 October 2010
Author:maxsem
Status:ok (Comments)
Tags:
Comment:
Follow-up r75327: add forgotten patch file, register it for SQLite.
Modified paths:
  • /trunk/extensions/CodeReview/CodeReview.php (modified) (history)
  • /trunk/extensions/CodeReview/archives/code_signoffs.sql (added) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/CodeReview.php
@@ -185,6 +185,7 @@
186186 break;
187187 case 'sqlite':
188188 $updater->addExtensionUpdate( array( 'addTable', 'code_rev', "$base/codereview.sql", true ) );
 189+ $updater->addExtensionUpdate( array( 'addTable', 'code_signoffs', "$base/archives/code_signoffs.sql", true ) );
189190 break;
190191 case 'postgres':
191192 // TODO
Index: trunk/extensions/CodeReview/archives/code_signoffs.sql
@@ -0,0 +1,17 @@
 2+CREATE TABLE /*_*/code_signoffs (
 3+ -- Repository ID and revision ID
 4+ cs_repo_id int not null,
 5+ cs_rev_id int not null,
 6+
 7+ -- User that signed off
 8+ cs_user_text varchar(255) not null,
 9+
 10+ -- Type of signoff. Current values: 'inspected', 'tested'
 11+ -- See CodeRevision::getPossibleFlags() (in backend/CodeRevision.php) for most up to date list
 12+ cs_flag varchar(25) not null,
 13+
 14+ -- Timestamp of the sign-off
 15+ cs_timestamp binary(14) not null default ''
 16+) /*$wgDBTableOptions*/;
 17+CREATE UNIQUE INDEX /*i*/cs_repo_rev_user_flag ON /*_*/code_signoffs (cs_repo_id, cs_rev_id, cs_user_text, cs_flag);
 18+CREATE INDEX /*i*/cs_repo_repo_rev_timestamp ON /*_*/code_signoffs (cs_repo_id, cs_rev_id, cs_timestamp);
Property changes on: trunk/extensions/CodeReview/archives/code_signoffs.sql
___________________________________________________________________
Added: svn:eol-style
119 + native

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r75327CodeReview: (bug 24380) Add sign-off feature where any coder can sign off on ...catrope18:16, 24 October 2010

Comments

#Comment by Catrope (talk | contribs)   18:40, 24 October 2010

Thanks!

Status & tagging log