r75324 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r75323‎ | r75324 | r75325 >
Date:17:36, 24 October 2010
Author:reedy
Status:ok
Tags:
Comment:
I still hate whitespace
Modified paths:
  • /trunk/extensions/CodeReview/ui/CodeRevisionCommitter.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/ui/CodeRevisionCommitter.php
@@ -57,22 +57,23 @@
5858 }
5959 $dbw->commit();
6060
61 - if ( $statusChanged || $commentAdded ) {
62 - if ( $statusChanged && $commentAdded ) {
63 - $url = $this->mRev->getFullUrl( $commentId );
64 - $this->mRev->emailNotifyUsersOfChanges( 'codereview-email-subj4', 'codereview-email-body4',
65 - $wgUser->getName(), $this->mRev->getIdStringUnique(), $this->mRev->mOldStatus, $this->mRev->mStatus,
 61+ if ( $statusChanged || $commentAdded ) {
 62+ if ( $statusChanged && $commentAdded ) {
 63+ $url = $this->mRev->getFullUrl( $commentId );
 64+ $this->mRev->emailNotifyUsersOfChanges( 'codereview-email-subj4', 'codereview-email-body4',
 65+ $wgUser->getName(), $this->mRev->getIdStringUnique(), $this->mRev->mOldStatus, $this->mRev->mStatus,
6666 $url, $this->text
67 - );
68 - } else if ( $statusChanged ) {
 67+ );
 68+ } else if ( $statusChanged ) {
6969 $this->mRev->emailNotifyUsersOfChanges( 'codereview-email-subj3', 'codereview-email-body3',
7070 $wgUser->getName(), $this->mRev->getIdStringUnique(), $this->mRev->mOldStatus, $this->mRev->mStatus
71 - );
72 - } else if ( $commentAdded ) {
73 - $url = $this->mRev->getFullUrl( $commentId );
74 - $this->mRev->emailNotifyUsersOfChanges( 'codereview-email-subj', 'codereview-email-body',
75 - $wgUser->getName(), $url, $this->mRev->getIdStringUnique(), $this->text );
76 - }
 71+ );
 72+ } else if ( $commentAdded ) {
 73+ $url = $this->mRev->getFullUrl( $commentId );
 74+ $this->mRev->emailNotifyUsersOfChanges( 'codereview-email-subj', 'codereview-email-body',
 75+ $wgUser->getName(), $url, $this->mRev->getIdStringUnique(), $this->text
 76+ );
 77+ }
7778 }
7879
7980 // Return to rev page

Status & tagging log