r75323 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r75322‎ | r75323 | r75324 >
Date:17:33, 24 October 2010
Author:reedy
Status:ok
Tags:
Comment:
Minor followup r75319, fix some moldStatus to mOldStatus
Modified paths:
  • /trunk/extensions/CodeReview/backend/CodeRevision.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/backend/CodeRevision.php
@@ -152,12 +152,12 @@
153153 }
154154 // Get the old status from the master
155155 $dbw = wfGetDB( DB_MASTER );
156 - $this->moldStatus = $dbw->selectField( 'code_rev',
 156+ $this->mOldStatus = $dbw->selectField( 'code_rev',
157157 'cr_status',
158158 array( 'cr_repo_id' => $this->mRepoId, 'cr_id' => $this->mId ),
159159 __METHOD__
160160 );
161 - if ( $this->moldStatus === $status ) {
 161+ if ( $this->mOldStatus === $status ) {
162162 return false; // nothing to do here
163163 }
164164 // Update status
@@ -176,7 +176,7 @@
177177 'cpc_repo_id' => $this->getRepoId(),
178178 'cpc_rev_id' => $this->getId(),
179179 'cpc_attrib' => 'status',
180 - 'cpc_removed' => $this->moldStatus,
 180+ 'cpc_removed' => $this->mOldStatus,
181181 'cpc_added' => $status,
182182 'cpc_timestamp' => $dbw->timestamp(),
183183 'cpc_user' => $user->getId(),
@@ -186,7 +186,7 @@
187187 );
188188 }
189189
190 - $this->sendStatusToUDP( $status, $this->moldStatus );
 190+ $this->sendStatusToUDP( $status, $this->mOldStatus );
191191
192192 return true;
193193 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r75319* (bug 25628) Send email on revision state change. Some refactoring, invertin...reedy17:05, 24 October 2010

Status & tagging log