r75148 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r75147‎ | r75148 | r75149 >
Date:13:14, 21 October 2010
Author:hartman
Status:deferred
Tags:
Comment:
This should not have to be unescaped. It is a value of an attribute in the Smil DOM, and should thus be plain utf-8 data.
Modified paths:
  • /branches/MwEmbedStandAlone/modules/SmilPlayer/mw.SmilLayout.js (modified) (history)

Diff [purge]

Index: branches/MwEmbedStandAlone/modules/SmilPlayer/mw.SmilLayout.js
@@ -430,7 +430,7 @@
431431 $j( smilElement).find('param').each(function( inx, paramNode ){
432432 paramText +='|' + $j( paramNode ).attr('name') +
433433 '= ' +
434 - unescape( $j( paramNode ).attr('value') ) +
 434+ $j( paramNode ).attr('value') +
435435 "\n";
436436 });
437437 // Close up the template call
@@ -992,4 +992,4 @@
993993 // Translate rootLayout properties into div
994994 return cssAttributes;
995995 }
996 -}
\ No newline at end of file
 996+}

Status & tagging log