r75149 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r75148‎ | r75149 | r75150 >
Date:13:16, 21 October 2010
Author:hartman
Status:deferred
Tags:
Comment:
Follow up to r75140, missed one usage of unescape in mw.Language.names
Modified paths:
  • /branches/MwEmbedStandAlone/modules/TimedText/remotes/RemoteMwTimedText.js (modified) (history)

Diff [purge]

Index: branches/MwEmbedStandAlone/modules/TimedText/remotes/RemoteMwTimedText.js
@@ -112,7 +112,7 @@
113113 $j( _this.target ).prepend(
114114 $j('<h3>')
115115 .html(
116 - gM(pageMsgKey, [ unescape( mw.Language.names[ _this.langKey ] ), $fileLink.html() ] )
 116+ gM(pageMsgKey, [ mw.Language.names[ _this.langKey ], $fileLink.html() ] )
117117 )
118118 );
119119 // Select the language if possible:

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r75140mw.Language.names are not stored as escaped text, thus does not require unesc...hartman12:07, 21 October 2010

Status & tagging log