r74956 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r74955‎ | r74956 | r74957 >
Date:18:20, 18 October 2010
Author:pdhanda
Status:ok (Comments)
Tags:
Comment:
Added to DefaultSettings
Modified paths:
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)
  • /trunk/phase3/includes/diff/DifferenceInterface.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/diff/DifferenceInterface.php
@@ -456,21 +456,23 @@
457457 $wgOut->addHTML( htmlspecialchars( $this->mNewtext ) );
458458 $wgOut->addHTML( "\n</pre>\n" );
459459 }
460 - } elseif( $pCache ) {
461 - $article = new Article( $this->mTitle, 0 );
462 - $pOutput = ParserCache::singleton()->get( $article, $wgOut->parserOptions() );
463 - if( $pOutput ) {
464 - $wgOut->addParserOutput( $pOutput );
 460+ } elseif( wfRunHooks( 'ArticleContentOnDiff', array( $this, &$wgOut ) ) ) {
 461+ if( $pCache ) {
 462+ $article = new Article( $this->mTitle, 0 );
 463+ $pOutput = ParserCache::singleton()->get( $article, $wgOut->parserOptions() );
 464+ if( $pOutput ) {
 465+ $wgOut->addParserOutput( $pOutput );
 466+ } else {
 467+ $article->doViewParse();
 468+ }
465469 } else {
466 - $article->doViewParse();
 470+ $wgOut->addWikiTextTidy( $this->mNewtext );
467471 }
468 - } else {
469 - $wgOut->addWikiTextTidy( $this->mNewtext );
470 - }
 472+ if( is_object( $this->mNewRev ) && !$this->mNewRev->isCurrent() ) {
 473+ $wgOut->parserOptions()->setEditSection( $oldEditSectionSetting );
 474+ }
 475+ }
471476
472 - if( is_object( $this->mNewRev ) && !$this->mNewRev->isCurrent() ) {
473 - $wgOut->parserOptions()->setEditSection( $oldEditSectionSetting );
474 - }
475477 # Add redundant patrol link on bottom...
476478 if( $this->mRcidMarkPatrolled && $this->mTitle->quickUserCan('patrol') ) {
477479 $sk = $wgUser->getSkin();
Index: trunk/phase3/includes/DefaultSettings.php
@@ -5121,6 +5121,7 @@
51225122 */
51235123 $wgEnableSelenium = false;
51245124 $wgSeleniumTestConfigs = array();
 5125+$wgSeleniumConfigFile = null;
51255126
51265127
51275128

Follow-up revisions

RevisionCommit summaryAuthorDate
r74957Reverted accidental changes to DifferenceInterface in r74956pdhanda18:28, 18 October 2010

Comments

#Comment by Nikerabbit (talk | contribs)   19:13, 18 October 2010

It's easy to see when somebody is using svn commit -m :)

#Comment by Pdhanda (talk | contribs)   19:33, 18 October 2010

yeah... i applied a patch and completely forgot :/

#Comment by Catrope (talk | contribs)   14:21, 20 October 2010

I think he meant the fact that "$wgFoo" dropped out of your commit message due to shell expansion.

As with your previous rev, please document these globals.

Status & tagging log